Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scd] oir upsert: check uss base URL and if both subscription ID and implicit request are specified #1097

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

Shastick
Copy link
Contributor

@Shastick Shastick commented Sep 2, 2024

These checks are now done explicitly and early.

This change of behavior was split off from #1094

It is part of the refactors for #1088

@Shastick Shastick changed the title [scd] oir upsert: fail early with Bad request if both a subscription ID and implicit request are specified [scd] oir upsert: check uss base URL and if both subscription ID and implicit request are specified Sep 3, 2024
Copy link
Contributor

@mickmis mickmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mickmis mickmis merged commit 074d12c into interuss:master Sep 3, 2024
6 checks passed
@mickmis mickmis deleted the oir-upsert-fail-if-both branch September 3, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants