[uss_qualifier] Fix query timestamp property reference (#799)

interuss · Oct 3, 2024 · 50daecb · 50daecb
1 parent 8f2dc53
commit 50daecb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/monitoring/monitorlib/fetch/__init__.py b/monitoring/monitorlib/fetch/__init__.py
@@ -434,6 +434,12 @@ class Query(ImplicitDict):
     query_type: Optional[QueryType]
     """If specified, the recognized type of this query."""
 
+    @property
+    def timestamp(self) -> datetime.datetime:
+        """Safety property to prevent crashes when Query.timestamp is accessed.
+        For intentional access, request.timestamp should be used instead."""
+        return self.request.timestamp
+
     @property
     def status_code(self) -> int:
         return self.response.status_code

diff --git a/monitoring/uss_qualifier/scenarios/astm/utm/versioning/evaluate_system_versions.py b/monitoring/uss_qualifier/scenarios/astm/utm/versioning/evaluate_system_versions.py
@@ -131,8 +131,8 @@ def _evaluate_versions(
         mismatch_timestamps = []
         for participant_id in mismatched_participants:
             timestamps = [
-                test_env_versions[participant_id].query.timestamp,
-                prod_env_versions[participant_id].query.timestamp,
+                test_env_versions[participant_id].query.request.timestamp,
+                prod_env_versions[participant_id].query.request.timestamp,
             ]
             with self.check(
                 "Test software version matches production", participants=participant_id