[uss_qualifier] Optimize RID tests #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickmis
approved these changes
Oct 18, 2023
| @@ -156,8 +156,15 @@ <h2>Scenarios executed</h2> | |||
| {% endif %} | |||
| <th>Scenario</th> | |||
| {% for participant_id in all_participants %} | |||
| <th>{{ participant_id }}</th> | |||
| <th> | |||
| {% if participant_id != "unattributed" %} | |||
There was a problem hiding this comment.
I'm not familiar with this templating, but is it possible to refer to the variable from here?
There was a problem hiding this comment.
Yes; the variable has to be passed into the templating engine specifically, but that's probably still a good idea. Will do.
github-actions bot
added a commit
that referenced
this pull request
Oct 18, 2023
* Add scenario durations to sequence view artifact * Optimize RID tests * Use unattributed participant constant in templates * Fix merge issue, improve error message ba6597c
github-actions bot
added a commit
to punamverma/monitoring
that referenced
this pull request
Oct 18, 2023
* Add scenario durations to sequence view artifact * Optimize RID tests * Use unattributed participant constant in templates * Fix merge issue, improve error message ba6597c
github-actions bot
added a commit
to openskies-sh/monitoring
that referenced
this pull request
Oct 20, 2023
* Add scenario durations to sequence view artifact * Optimize RID tests * Use unattributed participant constant in templates * Fix merge issue, improve error message ba6597c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, RID tests take a long time and we perform two of them in series (F3411-22a + U-space Remote Identification). This PR makes an effort to reduce the time these tests take by shortening the simulated flights and bringing in the lead time between injection and monitoring. It also removes the separate F3411-19 CI job in favor of resolving the TODO to add the netrid_v19 test to the standard set of tests.
In the process of making these changes, a number of issues were resolved or improved: