[monitorlib, uss_qualifier] Add flight_planning client and resource #284
Conversation
| return self._inject(flight_id, updated_flight_info, execution_style) | ||
|
|
||
| def try_end_flight( | ||
| self, flight_id: FlightID, execution_style: ExecutionStyle |
There was a problem hiding this comment.
execution_style is not used. Should it be removed or the value be checked to only allow IfAllowed ?
There was a problem hiding this comment.
Hmm, this is probably a larger question for the API. The issue is that a standard RESTful DELETE cannot carry a request body, so we can't easily deliver the execution style to this endpoint (hypothetically it could be a query argument, but that's not a very standard way of using those arguments I think). It seems like the standard upsert operation could be used to handle a graceful delete (actually cancel/close), and then this endpoint could be used only as a cleanup of last resort. Added the check you suggested in the mean time (will push after merging main after merging other PR).
This PR adds a FlightPlannerClient implementation for the flight_planning interface and adjusts the FlightPlanner uss_qualifier resource to optionally use it.
The functionality in the new client is not exercised as doing so would require a mock_uss implementation of the API (and a PR of the mock_uss implementation of the API would require the content in this PR) and putting both things in one PR would make a very large PR. So, this PR is intended to commit a draft of the client to reduce the size of the PR that adds the mock_uss implementation of the API.