[uss_qualifier] Reduce check customization #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
added a commit
that referenced
this pull request
Dec 15, 2023
* Specify participants only upon check initiation * Specify requirements only upon check initiation * Fix common_data_dictionary b804cf4
This was referenced Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a check initiated in a test scenario can have some of its properties overridden when it is declared passed or failed -- specifically, the participant(s) to which the check pertains and/or the requirements relevant to the check. I believe these overrides have only ever been used incorrectly or redundantly. They add complexity and reduce the tight coupling between documentation and test scenario behavior (in the case of requirements). This PR simplifies and unifies check behavior by eliminating the ability to mutate a check upon pass or fail declaration.
The only existing usages of the fail-time participants specification I believe are redundant because the NetRID CI report does not appear to have any more unattributed checks after the removals in this PR than it did before this PR.