[uss_qualifier] Allow mock_uss to be omitted from F3548-related test configurations #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barroco
approved these changes
Dec 14, 2023
In an ideal world, yes. Unfortunately, we have a practicality problem in that our existing tests already take a fair amount of time (almost 15 minutes) so I think we want to be fairly circumspect about increasing that time -- doing so should be for valuable tests, and I don't think this particular configuration permutation is likely to make the bar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, F3548-related test configurations cannot be run without providing a mock_uss instance. It should be possible to still run most of the test without a mock_uss instance, so that resource should be optional. This PR makes that change and enables F3548-related test configurations that do not provide a mock_uss instance.