-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[uss_qualifier] Add U-space MSL test scenario #413
[uss_qualifier] Add U-space MSL test scenario #413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Few comments inline.
@@ -0,0 +1,7 @@ | |||
# U-space Article 8: Network Identification Service | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A reference link to the regulation may be useful: https://eur-lex.europa.eu/legal-content/EN/TXT/HTML/?uri=CELEX:32021R0664&qid=1702917443967#d1e905-161-1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment apply for amc/gm references
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added links
|
||
#### ⚠️ MSL altitude is correct check | ||
|
||
In the previously-conducted test scenario, UAS altitudes were injected relative to the WGS84 ellipsoid. Since the EGM96 geoid is a standard shape that is well-defined relative to the WGS84 ellipsoid, this means the altitude relative to the EGM96 is defined by the injection. If the observed MSL altitude differs from the injected MSL altitude, then the USSP has failed to allow the automated authorised user to receive messages with the UAS's altitude above mean sea level per **[uspace.article8.MSLAltitude](../../../requirements/uspace/article8.md)** because the altitude reported was not the altitude of the UAS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to specify an error tolerance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I don't think the requirements specify an error tolerance, I would expect we wouldn't mention it in the documentation and we would pick a value in implementation that doesn't cause any false positives while minimizing false negatives.
|
||
## Article 8(2)(c) | ||
|
||
_The network identification service shall allow for the authorised users to receive messages with the geographical position of the UAS, its altitude above mean sea level and its height above the surface or take-off point._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: For clarity, it would be benefitial to emphasize the fact that "authorised user" is a concept defined in the regulation and so the reader would not assume that the user / uss_qualifier require some privilege to access this data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added Article 8(4) definition of authorised users
* Add U-space MSL test scenario * Address comments 20a0a81
According to ASTM's mapping of U-space Article 8 Network Identification, the one requirement not covered by the use of ASTM F3411-22a is provision of MSL altitude to authorised users (Article 8(2)(c)). This PR adds documentation for a test scenario specific to U-space to verify compliance to that requirement along with a blank implementation, and adds that scenario to the U-space Network Identification Service test suite.