-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[uss_qualifier] check off DSS0215 and DSS020 for subscriptions (partial) #533
Conversation
35e4d5a
to
4e845eb
Compare
d133221
to
f27104d
Compare
404b289
to
946a509
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content of this PR looks good to me, but the auto-generated suite documentation seems to perhaps only be reflecting one of the associated requirements and ignoring other associated requirements since a lot of requirements previously indicated as being checked by the suite are removed in this PR. I think we'll need to fix that presumed bug before we'd want to apply this change so as to avoid losing indicated coverage in the auto-generated documentation
946a509
to
5845f8e
Compare
Interesting. Might that be due to the fact that two of the requirements are mentioned in a markdown list? I'll try to mention these without a list to see if it fixes it. edit: @BenjaminPelletier indeed, removing the markdown list (as done in this commit) results in the requirements being taken into consideration again. edit2: Bug tracked in #561 edit3: it seems we have some flaky RID tests again. Tracking this in #563 |
5845f8e
to
dede211
Compare
DSS0215 (Write to DAR before returning to caller) and DSS020 (access to any DSS yields same results) can easily be partially covered by the existing subscription synchronization check.
This covers the 'broadcast' part (write on main, query secondaries) of the subscription synchronization checks.
Missing coverage is tracked in #434