Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uss_qualifier] check off DSS0215 and DSS020 for subscriptions (partial) #533

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

Shastick
Copy link
Contributor

@Shastick Shastick commented Mar 7, 2024

DSS0215 (Write to DAR before returning to caller) and DSS020 (access to any DSS yields same results) can easily be partially covered by the existing subscription synchronization check.

This covers the 'broadcast' part (write on main, query secondaries) of the subscription synchronization checks.

Missing coverage is tracked in #434

@Shastick Shastick force-pushed the dss0215-dar-req branch 2 times, most recently from 35e4d5a to 4e845eb Compare March 7, 2024 14:55
@Shastick Shastick marked this pull request as ready for review March 7, 2024 15:34
@Shastick Shastick force-pushed the dss0215-dar-req branch 2 times, most recently from d133221 to f27104d Compare March 11, 2024 19:21
@Shastick Shastick marked this pull request as draft March 12, 2024 15:14
@Shastick Shastick force-pushed the dss0215-dar-req branch 3 times, most recently from 404b289 to 946a509 Compare March 13, 2024 07:17
@Shastick Shastick marked this pull request as ready for review March 13, 2024 07:17
Copy link
Member

@BenjaminPelletier BenjaminPelletier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content of this PR looks good to me, but the auto-generated suite documentation seems to perhaps only be reflecting one of the associated requirements and ignoring other associated requirements since a lot of requirements previously indicated as being checked by the suite are removed in this PR. I think we'll need to fix that presumed bug before we'd want to apply this change so as to avoid losing indicated coverage in the auto-generated documentation

@Shastick
Copy link
Contributor Author

Shastick commented Mar 15, 2024

The content of this PR looks good to me, but the auto-generated suite documentation seems to perhaps only be reflecting one of the associated requirements and ignoring other associated requirements since a lot of requirements previously indicated as being checked by the suite are removed in this PR. I think we'll need to fix that presumed bug before we'd want to apply this change so as to avoid losing indicated coverage in the auto-generated documentation

Interesting. Might that be due to the fact that two of the requirements are mentioned in a markdown list?

I'll try to mention these without a list to see if it fixes it.

edit: @BenjaminPelletier indeed, removing the markdown list (as done in this commit) results in the requirements being taken into consideration again.

edit2: Bug tracked in #561

edit3: it seems we have some flaky RID tests again. Tracking this in #563

@Shastick Shastick changed the title [uss_qualifier] check off DSS0215 and DSS020 for subscriptions [uss_qualifier] check off DSS0215 and DSS020 for subscriptions (reads) Mar 15, 2024
@Shastick Shastick changed the title [uss_qualifier] check off DSS0215 and DSS020 for subscriptions (reads) [uss_qualifier] check off DSS0215 and DSS020 for subscriptions Mar 15, 2024
@Shastick Shastick changed the title [uss_qualifier] check off DSS0215 and DSS020 for subscriptions [uss_qualifier] check off DSS0215 and DSS020 for subscriptions (partial) Mar 15, 2024
@BenjaminPelletier BenjaminPelletier merged commit a4d3ed3 into interuss:main Mar 18, 2024
9 checks passed
github-actions bot added a commit that referenced this pull request Mar 18, 2024
…al) (#533)

* dss-0215 check off DSS0215 and DSS020 for subscriptions

* Without markdown list a4d3ed3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants