New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qualifier] DSS0210,A2-7-2,7 validate authentication for OIR CRUD+search endpoints #546

Merged

mickmis merged 3 commits into interuss:main from Orbitalize:dss0210-a7-oir

Mar 21, 2024

Contributor

Shastick commented Mar 12, 2024 •

edited

Loading

Extend the authentication checking scenario to include the OIR endpoint.

Shastick force-pushed the dss0210-a7-oir branch from fc6b021 to 3164586 Compare

March 12, 2024 07:50

Shastick mentioned this pull request

Implement tests for F3548 DSS requirements #434

Open

Shastick force-pushed the dss0210-a7-oir branch 4 times, most recently from d335fb6 to d1d47b3 Compare

March 15, 2024 09:42

Shastick marked this pull request as ready for review

March 15, 2024 10:56

Member

BenjaminPelletier commented Mar 18, 2024

If a PR is not ready for review (because, for instance, it depends on another PR that has not yet been merged), let's mark it as draft since it is not yet ready for review.

Shastick marked this pull request as draft

March 19, 2024 10:25

Shastick force-pushed the dss0210-a7-oir branch 2 times, most recently from a2dbc13 to adc4535 Compare

March 19, 2024 16:01

Shastick marked this pull request as ready for review

March 19, 2024 16:02

Shastick force-pushed the dss0210-a7-oir branch 2 times, most recently from 299262e to 23bcc8f Compare

March 20, 2024 13:36

mickmis reviewed

View reviewed changes

monitoring/uss_qualifier/scenarios/astm/utm/dss/test_step_fragments.py Outdated Show resolved Hide resolved

monitoring/uss_qualifier/scenarios/astm/utm/dss/test_step_fragments.py Outdated Show resolved Hide resolved

monitoring/uss_qualifier/scenarios/astm/utm/dss/authentication/authentication_validation.py Outdated Show resolved Hide resolved

monitoring/uss_qualifier/scenarios/astm/utm/dss/authentication/authentication_validation.py Outdated Show resolved Hide resolved

monitoring/uss_qualifier/scenarios/astm/utm/dss/authentication/authentication_validation.py Outdated Show resolved Hide resolved

monitoring/uss_qualifier/scenarios/astm/utm/dss/authentication/oir_api_validator.py Outdated Show resolved Hide resolved

monitoring/uss_qualifier/scenarios/astm/utm/dss/authentication/oir_api_validator.py Show resolved Hide resolved

monitoring/uss_qualifier/scenarios/astm/utm/dss/authentication/oir_api_validator.py Outdated Show resolved Hide resolved

monitoring/uss_qualifier/scenarios/astm/utm/dss/authentication/oir_api_validator.py Outdated Show resolved Hide resolved

monitoring/uss_qualifier/scenarios/astm/utm/dss/authentication/oir_api_validator.py Show resolved Hide resolved

Shastick force-pushed the dss0210-a7-oir branch 2 times, most recently from e0f8777 to 841fd38 Compare

March 20, 2024 16:43

Shastick commented

View reviewed changes

Contributor Author

Shastick left a comment •

edited

Loading

First batch of updates. (Covers everything except for two things that require a rebase on top of #535, I'll try to have this done by tomorrow)

monitoring/uss_qualifier/scenarios/astm/utm/dss/authentication/oir_api_validator.py

+                          with self._scenario.check(
+                              "Create operational intent reference with missing scope", self._pid
+                          ) as check:
+                              if no_scope_q.status_code != 401:

Contributor Author

Shastick Mar 20, 2024

Our DSS currently returns a 401 here, which stands for Unauthorized which is not false if a scope is missing. (403 is Forbidden and would not be wrong either)

I'll fix the comment below

monitoring/uss_qualifier/scenarios/astm/utm/dss/authentication/oir_api_validator.py Show resolved Hide resolved

monitoring/uss_qualifier/scenarios/astm/utm/dss/authentication/authentication_validation.py Outdated Show resolved Hide resolved

monitoring/uss_qualifier/scenarios/astm/utm/dss/authentication/oir_api_validator.py Show resolved Hide resolved

Shastick force-pushed the dss0210-a7-oir branch 2 times, most recently from eb86908 to e539259 Compare

March 20, 2024 18:54

Shastick requested a review from mickmis

March 20, 2024 18:55

Contributor Author

Shastick commented Mar 20, 2024

@mickmis I integrated the latest OIR fragments (and even split the create and update ones for OIR), this is ready for review.

Shastick force-pushed the dss0210-a7-oir branch 2 times, most recently from 762cead to 6266987 Compare

March 21, 2024 10:46

mickmis approved these changes

View reviewed changes

Contributor

mickmis left a comment

LGTM - please fix the remaining 403 though before merging

monitoring/uss_qualifier/scenarios/astm/utm/dss/authentication/oir_api_validator.py Outdated Show resolved Hide resolved

monitoring/uss_qualifier/scenarios/astm/utm/dss/authentication/oir_api_validator.py Outdated Show resolved Hide resolved

monitoring/uss_qualifier/scenarios/astm/utm/dss/fragments/oir/crud/create_format.md Outdated Show resolved Hide resolved

Shastick added 2 commits

March 21, 2024 11:55


          DSS0210,A2-7-2,7 OIR

1a882ed


          PR comments

11e5b60

Shastick force-pushed the dss0210-a7-oir branch from 6266987 to a5c4b72 Compare

March 21, 2024 10:58


          last fixes

f1334ac

Shastick force-pushed the dss0210-a7-oir branch from a5c4b72 to f1334ac Compare

March 21, 2024 11:00

mickmis merged commit 08d09cc into interuss:main

9 checks passed

github-actions bot added a commit that referenced this pull request


          [qualifier] DSS0210,A2-7-2,7 validate authentication for OIR CRUD+sea…

968afab

…rch endpoints (#546)

* DSS0210,A2-7-2,7 OIR

* PR comments

* last fixes 08d09cc

Shastick mentioned this pull request

[uss_qualifier] scd endpoint auth validation: cover uss availability #710

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet