Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync vue-demi dependency #83

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

BobbieGoede
Copy link
Member

@BobbieGoede BobbieGoede commented Nov 30, 2023

Description

Not sure if vue-demi version was specifically set, but the mismatch between vue-i18n-routing and @intlify/vue-router-bridge may be causing issues downstream in @nuxtjs/i18n. It seems vue-demi hardly if ever introduce breaking changes, using this version range will assume any newer version will be non breaking, perhaps this is too lenient?

This branch should not be merged until intlify/bridging#50 has been merged and its version has been updated in the package file here.

Linked Issues

Additional context

@BobbieGoede BobbieGoede force-pushed the fix/sync-vue-demi-dependency branch from 1af09d1 to 6457365 Compare December 1, 2023 11:44
@kazupon kazupon added the bug Includes new features label Dec 4, 2023
@kazupon
Copy link
Member

kazupon commented Dec 4, 2023

@BobbieGoede
I've just released @intlify/vue-i18n-bridge and @intlify/vue-router-bridge latest version.
You can update this PR

@BobbieGoede BobbieGoede marked this pull request as ready for review December 4, 2023 15:41
@kazupon kazupon merged commit a1c520e into intlify:main Dec 4, 2023
5 checks passed
@BobbieGoede
Copy link
Member Author

Such a strange error on the first e2e install run, maybe it was too quick after release? 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Includes new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants