config: add LogoNotFoundError

invenio_communities/communities/resources/config.py

@@ -31,6 +31,7 @@
 from invenio_communities.errors import (
     CommunityDeletedError,
     CommunityFeaturedEntryDoesNotExistError,
+    LogoNotFoundError,
     LogoSizeLimitError,
     OpenRequestsForCommunityDeletionError,
     SetDefaultCommunityError,
@@ -39,7 +40,7 @@
 community_error_handlers = RecordResourceConfig.error_handlers.copy()
 community_error_handlers.update(
     {
-        FileNotFoundError: create_error_handler(
+        LogoNotFoundError: create_error_handler(
             HTTPJSONException(
                 code=404,
                 description="No logo exists for this community.",

invenio_communities/communities/services/service.py

@@ -38,6 +38,7 @@
 )
 from invenio_communities.errors import (
     CommunityFeaturedEntryDoesNotExistError,
+    LogoNotFoundError,
     LogoSizeLimitError,
     OpenRequestsForCommunityDeletionError,
 )
@@ -235,7 +236,7 @@ def read_logo(self, identity, id_):
         self.require_permission(identity, "read", record=record)
         logo_file = record.files.get("logo")
         if logo_file is None:
-            raise FileNotFoundError()
+            raise LogoNotFoundError()
         return self.files.file_result_item(
             self.files,
             identity,
@@ -277,7 +278,7 @@ def delete_logo(self, identity, id_, uow=None):
         self.require_permission(identity, "update", record=record)
         deleted_file = record.files.pop("logo", None)
         if deleted_file is None:
-            raise FileNotFoundError()
+            raise LogoNotFoundError()
 
         deleted_file.delete(force=True)
 

invenio_communities/errors.py

@@ -31,6 +31,14 @@ def __init__(self, query_arguments):
         )
 
 
+class LogoNotFoundError(CommunityError):
+    """The logo was not found."""
+
+    def __init__(self):
+        """Initialise error."""
+        super().__init__(_("No logo exists for this community."))
+
+
 class LogoSizeLimitError(CommunityError):
     """The provided logo size exceeds limit."""
 

invenio_communities/views/communities.py

@@ -22,7 +22,7 @@
 from invenio_communities.proxies import current_communities
 
 from ..communities.resources.ui_schema import TypesSchema
-from ..members.records.api import Member
+from ..errors import LogoNotFoundError
 from .decorators import pass_community
 from .template_loader import CommunityThemeChoiceJinjaLoader
 
@@ -360,7 +360,7 @@ def communities_settings(pid_value, community, community_ui):
     try:
         current_communities.service.read_logo(g.identity, pid_value)
         logo = True
-    except FileNotFoundError:
+    except LogoNotFoundError:
         logo = False
 
     logo_size_limit = 10**6

invenio_communities/views/ui.py

@@ -24,7 +24,7 @@
 )
 from invenio_communities.proxies import current_communities
 
-from ..errors import CommunityDeletedError
+from ..errors import CommunityDeletedError, LogoNotFoundError
 from ..searchapp import search_app_context
 from .communities import (
     communities_about,
@@ -256,7 +256,7 @@ def resolve_community_logo(logo_link, community_id):
                 identity=g.identity,
                 id_=community_id,
             )
-        except FileNotFoundError:
+        except LogoNotFoundError:
             return url_for("static", filename="images/square-placeholder.png")
 
         return logo_link