Hide "Plugin Settings" for plugin without "settings" mixin

inventree · Oct 2, 2024 · f14b64c · f14b64c
1 parent d784ecc
commit f14b64c
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 11 deletions.
diff --git a/src/frontend/src/components/plugins/PluginDrawer.tsx b/src/frontend/src/components/plugins/PluginDrawer.tsx
@@ -1,6 +1,7 @@
 import { t } from '@lingui/macro';
 import { Accordion, Alert, Card, Stack, Text } from '@mantine/core';
 import { IconExclamationCircle } from '@tabler/icons-react';
+import { useMemo } from 'react';
 
 import { ApiEndpoints } from '../../enums/ApiEndpoints';
 import { useInstance } from '../../hooks/UseInstance';
@@ -28,6 +29,10 @@ export default function PluginDrawer({
     refetchOnMount: true
   });
 
+  const hasSettings: boolean = useMemo(() => {
+    return !!pluginInstance?.mixins?.settings;
+  }, [pluginInstance]);
+
   if (!pluginInstance.active) {
     return (
       <Alert
@@ -116,16 +121,18 @@ export default function PluginDrawer({
             </Stack>
           </Accordion.Panel>
         </Accordion.Item>
-        <Accordion.Item value="plugin-settings">
-          <Accordion.Control>
-            <StylishText size="lg">{t`Plugin Settings`}</StylishText>
-          </Accordion.Control>
-          <Accordion.Panel>
-            <Card withBorder>
-              <PluginSettingList pluginKey={pluginKey} />
-            </Card>
-          </Accordion.Panel>
-        </Accordion.Item>
+        {hasSettings && (
+          <Accordion.Item value="plugin-settings">
+            <Accordion.Control>
+              <StylishText size="lg">{t`Plugin Settings`}</StylishText>
+            </Accordion.Control>
+            <Accordion.Panel>
+              <Card withBorder>
+                <PluginSettingList pluginKey={pluginKey} />
+              </Card>
+            </Accordion.Panel>
+          </Accordion.Item>
+        )}
         {pluginAdmin?.source && (
           <Accordion.Item value="plugin-custom">
             <Accordion.Control>

diff --git a/src/frontend/src/tables/plugin/PluginListTable.tsx b/src/frontend/src/tables/plugin/PluginListTable.tsx
@@ -375,7 +375,7 @@ export default function PluginListTable() {
       {activatePluginModal.modal}
       <DetailDrawer
         title={t`Plugin Detail`}
-        size={'50%'}
+        size={'65%'}
         renderContent={(pluginKey) => {
           if (!pluginKey) return;
           return (