update ends_with with a faster version

inverse-inc · Oct 3, 2024 · 4ab1f69 · 4ab1f69
1 parent 61bf6c1
commit 4ab1f69
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/lib/pf/util.pm b/lib/pf/util.pm
@@ -1887,10 +1887,6 @@ sub extract {
     return $default;
 }
 
-sub ends_with {
-    return $_[1] eq substr($_[0], -length($_[1]));
-}
-
 sub split_pem {
     my ($s) = @_;
     my @parts;
@@ -1981,6 +1977,10 @@ sub starts_with {
     return rindex($_[0], $_[1], 0) == 0;
 }
 
+sub ends_with {
+    return index($_[0], $_[1], -length($_[1])) != -1;
+}
+
 =back
 
 =head1 AUTHOR

diff --git a/t/util.t b/t/util.t
@@ -316,7 +316,7 @@ use Test::More;
 use Test::NoWarnings;
 
 BEGIN {
-    plan tests => 47 +
+    plan tests => 55 +
       ((scalar @NODE_ID_TESTS) * 3) +
       scalar @STRIP_FILENAME_FROM_EXCEPTIONS_TESTS +
       scalar @INVALID_DATES +
@@ -505,7 +505,15 @@ for my $test (@MAC2DEC) {
 
 {
     ok(starts_with("dog", "do"), "starts_with");
+    ok(starts_with("dog", "dog"), "starts_with");
+    ok(starts_with("dog", ""), "starts_with");
     ok(!starts_with("cat", "do"), "starts_with");
+    ok(!starts_with("cat", "catt"), "starts_with");
+    ok(ends_with("dog", "og"), "ends_with");
+    ok(ends_with("dog", "dog"), "ends_with");
+    ok(ends_with("dog", ""), "ends_with");
+    ok(!ends_with("cat", "og"), "ends_with");
+    ok(!ends_with("cat", "catt"), "ends_with");
 }
 
 =head1 AUTHOR