Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify ci #1590

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Simplify ci #1590

merged 3 commits into from
Oct 22, 2024

Conversation

notaphplover
Copy link
Member

Description

  • Action versions have been updated
  • Updated CI to stop relying in uploading and downloading artifacts. Instead, code coverage is generated once and uploaded once.

Motivation and Context

  • Fix CI so it stops failing when uploading test coverage artifacts.

Types of changes

  • Updated docs / Refactor code / Added a tests case (non-breaking change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the changelog.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.80%. Comparing base (6e97383) to head (de2ff2f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1590      +/-   ##
==========================================
+ Coverage   99.78%   99.80%   +0.02%     
==========================================
  Files          53       53              
  Lines        1369     1572     +203     
  Branches      200      209       +9     
==========================================
+ Hits         1366     1569     +203     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@notaphplover notaphplover merged commit 6cc8ed9 into master Oct 22, 2024
10 checks passed
@notaphplover notaphplover deleted the chore/simplify-ci branch October 22, 2024 19:19
@rsaz rsaz requested review from rsaz and removed request for rsaz October 22, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant