Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow middlewares to be auto bound #316

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow middlewares to be auto bound #316

wants to merge 1 commit into from

Conversation

rtomchinsky
Copy link

Description

This PR allows the middleware to be resolved when autoBindInjectables is true, by checking the container options and getting the middleware instead of checking if it is bound.

Motivation and Context

When creating the container with autoBindInjectables: true, and using middlewares without explicitly binding them, the middleware resolution fails because it is not bound at the time, and then the request errors because the class is used as a middleware.

How Has This Been Tested?

A new test was created in base_middleware.test.ts which creates a Container with autoBindInjectables set to true and then using the middleware in a controller method

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant