fix(core): update getClassElementMetadataFromLegacyMetadata

update getClassElementMetadataFromLegacyMetadata to fetch right name and target name
inversify · Nov 6, 2024 · 6469c67 · 6469c67
1 parent 20f58ea
commit 6469c67
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 10 deletions.
diff --git a/.changeset/wild-clouds-complain.md b/.changeset/wild-clouds-complain.md
@@ -0,0 +1,5 @@
+---
+"@inversifyjs/core": patch
+---
+
+Updated `getClassMetadata` to correctly fetch name and target names
diff --git a/...ibraries/core/src/metadata/calculations/getClassElementMetadataFromLegacyMetadata.spec.ts b/...ibraries/core/src/metadata/calculations/getClassElementMetadataFromLegacyMetadata.spec.ts
@@ -2,6 +2,8 @@ import { beforeAll, describe, expect, it } from '@jest/globals';
 
 import { ServiceIdentifier } from '@inversifyjs/common';
 
+import { InversifyCoreError } from '../../error/models/InversifyCoreError';
+import { InversifyCoreErrorKind } from '../../error/models/InversifyCoreErrorKind';
 import {
   INJECT_TAG,
   MULTI_INJECT_TAG,
@@ -38,11 +40,12 @@ describe(getClassElementMetadataFromLegacyMetadata.name, () => {
       });
 
       it('should throw an Error', () => {
-        const expectedErrorProperties: Partial<Error> = {
+        const expectedErrorProperties: Partial<InversifyCoreError> = {
+          kind: InversifyCoreErrorKind.missingInjectionDecorator,
           message: 'Expected @inject, @multiInject or @unmanaged metadata',
         };
 
-        expect(result).toBeInstanceOf(Error);
+        expect(result).toBeInstanceOf(InversifyCoreError);
         expect(result).toStrictEqual(
           expect.objectContaining(expectedErrorProperties),
         );
@@ -121,12 +124,13 @@ describe(getClassElementMetadataFromLegacyMetadata.name, () => {
         });
 
         it('should throw an Error', () => {
-          const expectedErrorProperties: Partial<Error> = {
+          const expectedErrorProperties: Partial<InversifyCoreError> = {
+            kind: InversifyCoreErrorKind.missingInjectionDecorator,
             message:
               'Expected a single @inject, @multiInject or @unmanaged metadata',
           };
 
-          expect(result).toBeInstanceOf(Error);
+          expect(result).toBeInstanceOf(InversifyCoreError);
           expect(result).toStrictEqual(
             expect.objectContaining(expectedErrorProperties),
           );
@@ -225,15 +229,15 @@ describe(getClassElementMetadataFromLegacyMetadata.name, () => {
           value: 'customTagValue',
         };
         nameMetadataFixture = {
-          key: NAME_TAG,
+          key: NAMED_TAG,
           value: 'name-fixture',
         };
         optionalMetadataFixture = {
           key: OPTIONAL_TAG,
           value: true,
         };
         targetNameMetadataFixture = {
-          key: NAMED_TAG,
+          key: NAME_TAG,
           value: 'target-name-fixture',
         };
         metadataListFixture = [

diff --git a/...ner/libraries/core/src/metadata/calculations/getClassElementMetadataFromLegacyMetadata.ts b/...ner/libraries/core/src/metadata/calculations/getClassElementMetadataFromLegacyMetadata.ts
@@ -1,5 +1,7 @@
 import { LazyServiceIdentifier, ServiceIdentifier } from '@inversifyjs/common';
 
+import { InversifyCoreError } from '../../error/models/InversifyCoreError';
+import { InversifyCoreErrorKind } from '../../error/models/InversifyCoreErrorKind';
 import {
   INJECT_TAG,
   MULTI_INJECT_TAG,
@@ -39,19 +41,22 @@ export function getClassElementMetadataFromLegacyMetadata(
   }
 
   if (multiInjectMetadata === undefined && injectMetadata === undefined) {
-    throw new Error('Expected @inject, @multiInject or @unmanaged metadata');
+    throw new InversifyCoreError(
+      InversifyCoreErrorKind.missingInjectionDecorator,
+      'Expected @inject, @multiInject or @unmanaged metadata',
+    );
   }
 
   const nameMetadata: LegacyMetadata | undefined = metadataList.find(
-    (metadata: LegacyMetadata): boolean => metadata.key === NAME_TAG,
+    (metadata: LegacyMetadata): boolean => metadata.key === NAMED_TAG,
   );
 
   const optionalMetadata: LegacyMetadata | undefined = metadataList.find(
     (metadata: LegacyMetadata): boolean => metadata.key === OPTIONAL_TAG,
   );
 
   const targetNameMetadata: LegacyMetadata | undefined = metadataList.find(
-    (metadata: LegacyMetadata): boolean => metadata.key === NAMED_TAG,
+    (metadata: LegacyMetadata): boolean => metadata.key === NAME_TAG,
   );
 
   const managedClassElementMetadata: ManagedClassElementMetadata = {
@@ -90,7 +95,8 @@ function getUnmanagedClassElementMetadata(
   multiInjectMetadata: LegacyMetadata | undefined,
 ): UnmanagedClassElementMetadata {
   if (multiInjectMetadata !== undefined || injectMetadata !== undefined) {
-    throw new Error(
+    throw new InversifyCoreError(
+      InversifyCoreErrorKind.missingInjectionDecorator,
       'Expected a single @inject, @multiInject or @unmanaged metadata',
     );
   }