feat(core): remove target name modules

inversify · Jan 11, 2025 · 7f97e76 · 7f97e76
1 parent 4aa18f3
commit 7f97e76
Show file tree

Hide file tree

Showing 44 changed files with 24 additions and 726 deletions.
diff --git a/.changeset/calm-fireants-tie.md b/.changeset/calm-fireants-tie.md
@@ -0,0 +1,5 @@
+---
+"@inversifyjs/core": major
+---
+
+Removed `MetadataTargetName`
diff --git a/.changeset/orange-carrots-hang.md b/.changeset/orange-carrots-hang.md
@@ -0,0 +1,5 @@
+---
+"@inversifyjs/core": major
+---
+
+Updated `ManagedClassElementMetadata` with no `targetName`
diff --git a/.changeset/tender-chairs-divide.md b/.changeset/tender-chairs-divide.md
@@ -0,0 +1,5 @@
+---
+"@inversifyjs/core": major
+---
+
+Updated `MaybeManagedClassElementMetadata` with no `targetName`
diff --git a/.changeset/warm-candles-prove.md b/.changeset/warm-candles-prove.md
@@ -0,0 +1,5 @@
+---
+"@inversifyjs/core": major
+---
+
+Removed `targetName`
diff --git a/packages/container/libraries/core/src/index.ts b/packages/container/libraries/core/src/index.ts
@@ -38,7 +38,6 @@ import { optional } from './metadata/decorators/optional';
 import { postConstruct } from './metadata/decorators/postConstruct';
 import { preDestroy } from './metadata/decorators/preDestroy';
 import { tagged } from './metadata/decorators/tagged';
-import { targetName } from './metadata/decorators/targetName';
 import { unmanaged } from './metadata/decorators/unmanaged';
 import { ClassElementMetadata } from './metadata/models/ClassElementMetadata';
 import { ClassElementMetadataKind } from './metadata/models/ClassElementMetadataKind';
@@ -47,7 +46,6 @@ import { ClassMetadataLifecycle } from './metadata/models/ClassMetadataLifecycle
 import { ManagedClassElementMetadata } from './metadata/models/ManagedClassElementMetadata';
 import { MetadataName } from './metadata/models/MetadataName';
 import { MetadataTag } from './metadata/models/MetadataTag';
-import { MetadataTargetName } from './metadata/models/MetadataTargetName';
 import { UnmanagedClassElementMetadata } from './metadata/models/UnmanagedClassElementMetadata';
 import { plan } from './planning/calculations/plan';
 import { BaseBindingNode } from './planning/models/BaseBindingNode';
@@ -101,7 +99,6 @@ export type {
   ManagedClassElementMetadata,
   MetadataName,
   MetadataTag,
-  MetadataTargetName,
   OptionalGetOptions,
   PlanBindingNode,
   PlanParams,
@@ -144,6 +141,5 @@ export {
   resolveModuleDeactivations,
   resolveServiceDeactivations,
   tagged,
-  targetName,
   unmanaged,
 };
diff --git a/.../container/libraries/core/src/metadata/actions/decrementPendingClassMetadataCount.spec.ts b/.../container/libraries/core/src/metadata/actions/decrementPendingClassMetadataCount.spec.ts
@@ -27,7 +27,6 @@ describe(decrementPendingClassMetadataCount.name, () => {
         name: undefined,
         optional: false,
         tags: new Map(),
-        targetName: undefined,
       };
     });
 

diff --git a/...r/libraries/core/src/metadata/actions/updateMaybeClassMetadataConstructorArgument.spec.ts b/...r/libraries/core/src/metadata/actions/updateMaybeClassMetadataConstructorArgument.spec.ts
@@ -38,7 +38,6 @@ describe(updateMaybeClassMetadataConstructorArgument.name, () => {
         name: undefined,
         optional: false,
         tags: new Map(),
-        targetName: undefined,
         value: Symbol(),
       };
 

diff --git a/...es/container/libraries/core/src/metadata/actions/updateMaybeClassMetadataProperty.spec.ts b/...es/container/libraries/core/src/metadata/actions/updateMaybeClassMetadataProperty.spec.ts
@@ -38,7 +38,6 @@ describe(updateMaybeClassMetadataProperty.name, () => {
         name: undefined,
         optional: false,
         tags: new Map(),
-        targetName: undefined,
         value: Symbol(),
       };
 

diff --git a/packages/container/libraries/core/src/metadata/actions/updateMetadataName.spec.ts b/packages/container/libraries/core/src/metadata/actions/updateMetadataName.spec.ts
@@ -21,7 +21,6 @@ describe(updateMetadataName.name, () => {
         name: undefined,
         optional: false,
         tags: new Map(),
-        targetName: undefined,
         value: 'service-id',
       };
       nameFixture = 'name-fixture';
@@ -59,7 +58,6 @@ describe(updateMetadataName.name, () => {
         name: 'name-fixture',
         optional: false,
         tags: new Map(),
-        targetName: undefined,
         value: 'service-id',
       };
       nameFixture = 'name-fixture';

diff --git a/packages/container/libraries/core/src/metadata/actions/updateMetadataOptional.spec.ts b/packages/container/libraries/core/src/metadata/actions/updateMetadataOptional.spec.ts
@@ -19,7 +19,6 @@ describe(updateMetadataOptional.name, () => {
         name: undefined,
         optional: false,
         tags: new Map(),
-        targetName: undefined,
         value: 'service-id',
       };
     });
@@ -55,7 +54,6 @@ describe(updateMetadataOptional.name, () => {
         name: undefined,
         optional: true,
         tags: new Map(),
-        targetName: undefined,
         value: 'service-id',
       };
     });

diff --git a/packages/container/libraries/core/src/metadata/actions/updateMetadataTag.spec.ts b/packages/container/libraries/core/src/metadata/actions/updateMetadataTag.spec.ts
@@ -22,7 +22,6 @@ describe(updateMetadataTag.name, () => {
         name: undefined,
         optional: false,
         tags: new Map(),
-        targetName: undefined,
         value: 'service-id',
       };
       keyFixture = 'tag-fixture';
@@ -62,7 +61,6 @@ describe(updateMetadataTag.name, () => {
         name: undefined,
         optional: false,
         tags: new Map([['tag-fixture', Symbol()]]),
-        targetName: undefined,
         value: 'service-id',
       };
       keyFixture = 'tag-fixture';

diff --git a/packages/container/libraries/core/src/metadata/actions/updateMetadataTargetName.spec.ts b/packages/container/libraries/core/src/metadata/actions/updateMetadataTargetName.spec.ts
diff --git a/packages/container/libraries/core/src/metadata/actions/updateMetadataTargetName.ts b/packages/container/libraries/core/src/metadata/actions/updateMetadataTargetName.ts
diff --git a/.../src/metadata/calculations/buildClassElementMetadataFromMaybeClassElementMetadata.spec.ts b/.../src/metadata/calculations/buildClassElementMetadataFromMaybeClassElementMetadata.spec.ts
@@ -91,7 +91,6 @@ describe(buildClassElementMetadataFromMaybeClassElementMetadata.name, () => {
         name: undefined,
         optional: false,
         tags: new Map(),
-        targetName: undefined,
       };
     });
 

diff --git a/...re/src/metadata/calculations/buildClassElementMetadataFromTypescriptParameterType.spec.ts b/...re/src/metadata/calculations/buildClassElementMetadataFromTypescriptParameterType.spec.ts
@@ -26,7 +26,6 @@ describe(buildClassElementMetadataFromTypescriptParameterType.name, () => {
         name: undefined,
         optional: false,
         tags: new Map(),
-        targetName: undefined,
         value: typeFixture,
       };
 

diff --git a/...es/core/src/metadata/calculations/buildClassElementMetadataFromTypescriptParameterType.ts b/...es/core/src/metadata/calculations/buildClassElementMetadataFromTypescriptParameterType.ts
@@ -12,7 +12,6 @@ export function buildClassElementMetadataFromTypescriptParameterType(
     name: undefined,
     optional: false,
     tags: new Map(),
-    targetName: undefined,
     value: type,
   };
 }
diff --git a/...es/container/libraries/core/src/metadata/calculations/buildDefaultManagedMetadata.spec.ts b/...es/container/libraries/core/src/metadata/calculations/buildDefaultManagedMetadata.spec.ts
@@ -31,7 +31,6 @@ describe(buildDefaultManagedMetadata.name, () => {
         name: undefined,
         optional: false,
         tags: new Map(),
-        targetName: undefined,
         value: serviceIdentifierFixture,
       };
 

diff --git a/packages/container/libraries/core/src/metadata/calculations/buildDefaultManagedMetadata.ts b/packages/container/libraries/core/src/metadata/calculations/buildDefaultManagedMetadata.ts
@@ -14,7 +14,6 @@ export function buildDefaultManagedMetadata(
     name: undefined,
     optional: false,
     tags: new Map(),
-    targetName: undefined,
     value: serviceIdentifier,
   };
 }
diff --git a/...er/libraries/core/src/metadata/calculations/buildDefaultMaybeClassElementMetadata.spec.ts b/...er/libraries/core/src/metadata/calculations/buildDefaultMaybeClassElementMetadata.spec.ts
@@ -18,7 +18,6 @@ describe(buildDefaultMaybeClassElementMetadata.name, () => {
         name: undefined,
         optional: false,
         tags: new Map(),
-        targetName: undefined,
       };
 
       expect(result).toStrictEqual(expected);

diff --git a/...ntainer/libraries/core/src/metadata/calculations/buildDefaultMaybeClassElementMetadata.ts b/...ntainer/libraries/core/src/metadata/calculations/buildDefaultMaybeClassElementMetadata.ts
@@ -7,6 +7,5 @@ export function buildDefaultMaybeClassElementMetadata(): MaybeManagedClassElemen
     name: undefined,
     optional: false,
     tags: new Map(),
-    targetName: undefined,
   };
 }
diff --git a/...aries/core/src/metadata/calculations/buildManagedMetadataFromMaybeManagedMetadata.spec.ts b/...aries/core/src/metadata/calculations/buildManagedMetadataFromMaybeManagedMetadata.spec.ts
@@ -27,7 +27,6 @@ describe(buildManagedMetadataFromMaybeManagedMetadata.name, () => {
         name: 'name-fixture',
         optional: true,
         tags: new Map(),
-        targetName: 'target-name-fixture',
       };
 
       kindFixture = ClassElementMetadataKind.singleInjection;
@@ -57,7 +56,6 @@ describe(buildManagedMetadataFromMaybeManagedMetadata.name, () => {
         name: metadataFixture.name,
         optional: metadataFixture.optional,
         tags: metadataFixture.tags,
-        targetName: metadataFixture.targetName,
         value: serviceIdentifierFixture,
       };
 

diff --git a/...metadata/calculations/buildMaybeClassElementMetadataFromMaybeClassElementMetadata.spec.ts b/...metadata/calculations/buildMaybeClassElementMetadataFromMaybeClassElementMetadata.spec.ts
@@ -72,7 +72,6 @@ describe(
           name: undefined,
           optional: false,
           tags: new Map([['foo', 'bar']]),
-          targetName: undefined,
           value: 'service-identifier',
         };
         updateMetadataMock = jest.fn();

diff --git a/...ies/core/src/metadata/calculations/buildUnmanagedMetadataFromMaybeManagedMetadata.spec.ts b/...ies/core/src/metadata/calculations/buildUnmanagedMetadataFromMaybeManagedMetadata.spec.ts
@@ -22,7 +22,6 @@ describe(buildUnmanagedMetadataFromMaybeManagedMetadata.name, () => {
         name: 'name-fixture',
         optional: false,
         tags: new Map(),
-        targetName: undefined,
       },
     ],
     [
@@ -32,7 +31,6 @@ describe(buildUnmanagedMetadataFromMaybeManagedMetadata.name, () => {
         name: undefined,
         optional: true,
         tags: new Map(),
-        targetName: undefined,
       },
     ],
     [
@@ -42,17 +40,6 @@ describe(buildUnmanagedMetadataFromMaybeManagedMetadata.name, () => {
         name: undefined,
         optional: false,
         tags: new Map([['foo', 'bar']]),
-        targetName: undefined,
-      },
-    ],
-    [
-      'with targetName',
-      {
-        kind: MaybeClassElementMetadataKind.unknown,
-        name: undefined,
-        optional: false,
-        tags: new Map(),
-        targetName: 'target-name-fixture',
       },
     ],
   ])(
@@ -112,7 +99,6 @@ describe(buildUnmanagedMetadataFromMaybeManagedMetadata.name, () => {
         name: undefined,
         optional: false,
         tags: new Map(),
-        targetName: undefined,
       };
     });
 

diff --git a/...ibraries/core/src/metadata/calculations/buildUnmanagedMetadataFromMaybeManagedMetadata.ts b/...ibraries/core/src/metadata/calculations/buildUnmanagedMetadataFromMaybeManagedMetadata.ts
@@ -25,9 +25,6 @@ function hasManagedMetadata(
   metadata: MaybeManagedClassElementMetadata | ManagedClassElementMetadata,
 ): boolean {
   return (
-    metadata.name !== undefined ||
-    metadata.optional ||
-    metadata.tags.size > 0 ||
-    metadata.targetName !== undefined
+    metadata.name !== undefined || metadata.optional || metadata.tags.size > 0
   );
 }