Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional decorator #107

Merged
merged 2 commits into from
Nov 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
import { beforeAll, describe, expect, it } from '@jest/globals';

import { InversifyCoreError } from '../../error/models/InversifyCoreError';
import { InversifyCoreErrorKind } from '../../error/models/InversifyCoreErrorKind';
import { ClassElementMetadataKind } from '../models/ClassElementMetadataKind';
import { ManagedClassElementMetadata } from '../models/ManagedClassElementMetadata';
import { MaybeManagedClassElementMetadata } from '../models/MaybeManagedClassElementMetadata';
import { updateMetadataOptional } from './updateMetadataOptional';

describe(updateMetadataOptional.name, () => {
describe('having metadata with no optional', () => {
let metadataFixture:
| ManagedClassElementMetadata
| MaybeManagedClassElementMetadata;

beforeAll(() => {
metadataFixture = {
kind: ClassElementMetadataKind.singleInjection,
name: undefined,
optional: false,
tags: new Map(),
targetName: undefined,
value: 'service-id',
};
});

describe('when called', () => {
let result: unknown;

beforeAll(() => {
result = updateMetadataOptional(metadataFixture);
});

it('should return metadata', () => {
const expected:
| ManagedClassElementMetadata
| MaybeManagedClassElementMetadata = {
...metadataFixture,
optional: true,
};

expect(result).toStrictEqual(expected);
});
});
});

describe('having metadata with optional', () => {
let metadataFixture:
| ManagedClassElementMetadata
| MaybeManagedClassElementMetadata;

beforeAll(() => {
metadataFixture = {
kind: ClassElementMetadataKind.singleInjection,
name: undefined,
optional: true,
tags: new Map(),
targetName: undefined,
value: 'service-id',
};
});

describe('when called', () => {
let result: unknown;

beforeAll(() => {
try {
updateMetadataOptional(metadataFixture);
} catch (error: unknown) {
result = error;
}
});

it('should throw InversifyCoreError', () => {
const expectedErrorProperties: Partial<InversifyCoreError> = {
kind: InversifyCoreErrorKind.injectionDecoratorConflict,
message: 'Unexpected duplicated optional decorator',
};

expect(result).toBeInstanceOf(InversifyCoreError);
expect(result).toStrictEqual(
expect.objectContaining(expectedErrorProperties),
);
});
});
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import { InversifyCoreError } from '../../error/models/InversifyCoreError';
import { InversifyCoreErrorKind } from '../../error/models/InversifyCoreErrorKind';
import { ManagedClassElementMetadata } from '../models/ManagedClassElementMetadata';
import { MaybeManagedClassElementMetadata } from '../models/MaybeManagedClassElementMetadata';

export function updateMetadataOptional(
metadata: ManagedClassElementMetadata | MaybeManagedClassElementMetadata,
): ManagedClassElementMetadata | MaybeManagedClassElementMetadata {
if (metadata.optional) {
throw new InversifyCoreError(
InversifyCoreErrorKind.injectionDecoratorConflict,
'Unexpected duplicated optional decorator',
);
}

metadata.optional = true;

return metadata;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
import { beforeAll, describe, expect, it } from '@jest/globals';

import 'reflect-metadata';

import { getReflectMetadata } from '@inversifyjs/reflect-metadata-utils';

import { classMetadataReflectKey } from '../../reflectMetadata/data/classMetadataReflectKey';
import { MaybeClassElementMetadataKind } from '../models/MaybeClassElementMetadataKind';
import { MaybeClassMetadata } from '../models/MaybeClassMetadata';
import { optional } from './optional';

describe(optional.name, () => {
describe('when called', () => {
let result: unknown;

beforeAll(() => {
class Foo {
@optional()
public readonly bar!: string;

@optional()
public readonly baz!: string;

constructor(
@optional()
public firstParam: number,
@optional()
public secondParam: number,
) {}
}

result = getReflectMetadata(Foo, classMetadataReflectKey);
});

it('should return expected metadata', () => {
const expected: MaybeClassMetadata = {
constructorArguments: [
{
kind: MaybeClassElementMetadataKind.unknown,
name: undefined,
optional: true,
tags: new Map(),
targetName: undefined,
},
{
kind: MaybeClassElementMetadataKind.unknown,
name: undefined,
optional: true,
tags: new Map(),
targetName: undefined,
},
],
lifecycle: {
postConstructMethodName: undefined,
preDestroyMethodName: undefined,
},
properties: new Map([
[
'bar',
{
kind: MaybeClassElementMetadataKind.unknown,
name: undefined,
optional: true,
tags: new Map(),
targetName: undefined,
},
],
[
'baz',
{
kind: MaybeClassElementMetadataKind.unknown,
name: undefined,
optional: true,
tags: new Map(),
targetName: undefined,
},
],
]),
};

expect(result).toStrictEqual(expected);
});
});
});
Loading