Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add logger package #474

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[WIP] Add logger package #474

wants to merge 4 commits into from

Conversation

Adrianmjim
Copy link
Member

Added

  • Add logger package
  • Add console logger
  • Add file logger

@Adrianmjim Adrianmjim requested a review from notaphplover as a code owner March 8, 2025 08:48
@Adrianmjim Adrianmjim marked this pull request as draft March 8, 2025 08:48
notaphplover
notaphplover requested changes Mar 8, 2025
View reviewed changes
Copy link
Member

@notaphplover notaphplover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix some minor issues and merge it

packages/logger/libraries/core/README.md Outdated
Comment on lines 1 to 6
[![Test coverage](https://codecov.io/gh/inversify/monorepo/branch/main/graph/badge.svg?flag=%40inversifyjs%2Fhttp-core)](https://codecov.io/gh/inversify/monorepo/branch/main/graph/badge.svg?flag=%40inversifyjs%2Fhttp-core)
[![npm version](https://img.shields.io/github/package-json/v/inversify/monorepo?filename=packages%2Fcontainer%2Flibraries%2Fhttp-core%2Fpackage.json&style=plastic)](https://www.npmjs.com/package/@inversifyjs/http-core)

# @inversifyjs/http-core

Inversify monorepo http core modules.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change the links and title to @inversifyjs/logger

packages/logger/libraries/core/package.json Outdated
},
"version": "1.0.0",
"dependencies": {
"winston": "^3.17.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update it to be a peerDependency

@notaphplover
Copy link
Member

notaphplover commented Mar 8, 2025 •
edited
Loading

Let's create issues to implement remaining loggers and add unit tests

@notaphplover notaphplover self-assigned this Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notaphplover notaphplover notaphplover requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@notaphplover notaphplover

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Adrianmjim @notaphplover