Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allows firebase configuration file output path to be an absolute path #230

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,14 @@ String getFirebaseConfigurationFile({
final segments = removeForwardBackwardSlash(configurationFilePath).split('/');

if (segments.last.contains('.dart')) {
return path.join(
flutterAppPath,
removeForwardBackwardSlash(configurationFilePath),
);
if (path.isAbsolute(configurationFilePath)) {
return configurationFilePath;
} else {
return path.join(
flutterAppPath,
removeForwardBackwardSlash(configurationFilePath),
);
}
} else {
final configurationFilePath = promptInput(
'Enter a path for your FirebaseOptions file. It must be to a dart file. Example input: lib/firebase_options.dart',
Expand Down
30 changes: 30 additions & 0 deletions packages/flutterfire_cli/test/dart_file_prompts_test.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
import 'package:flutterfire_cli/src/common/prompts/dart_file_prompts.dart';
import 'package:test/test.dart';

void main() {
setUp(() async {});

tearDown(() {});

test('getFirebaseConfigurationFile concatenates app path and config file', () async {
const configFile = 'configfile.dart';
const flutterAppPath = '/Users/username/Projects/flutter_app';

final firebaseConfigurationFile =
getFirebaseConfigurationFile(configurationFilePath: configFile, flutterAppPath: flutterAppPath);

expect(firebaseConfigurationFile, equals('/Users/username/Projects/flutter_app/configfile.dart'));
});

test(
'When configuration file path is absolute, getFirebaseConfigurationFile does not concatenate app path and config file',
() async {
const configFile = '/Users/username/Projects/test/configfile.dart';
const flutterAppPath = '/Users/username/Projects/flutter_app';

final firebaseConfigurationFile =
getFirebaseConfigurationFile(configurationFilePath: configFile, flutterAppPath: flutterAppPath);

expect(firebaseConfigurationFile, equals(configFile));
});
}
Loading