Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add method to reload banner ad #579

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

dylancom
Copy link
Collaborator

@dylancom dylancom commented May 20, 2024

Description

As banner ads can become blank when an app was in background, the advise is to load a new ad upon returning to foreground. Therefore I added a method to make this possible.

@DoctorJohn @zoobibackups 👀?

@dylancom dylancom force-pushed the feature/reload-banner-ad branch 2 times, most recently from d2e0c8e to 1eaed70 Compare May 20, 2024 11:19
@dylancom dylancom requested a review from mikehardy May 20, 2024 11:22
@ugurdalkiran
Copy link
Contributor

It's a great feature. Thank you very much. 🥳

@DoctorJohn
Copy link
Contributor

Great changes @dylancom and straight forward code. I'll give them a quick test in my apps.

@dylancom dylancom force-pushed the feature/reload-banner-ad branch 4 times, most recently from 49a149b to 4d44123 Compare May 20, 2024 17:32
@dylancom dylancom force-pushed the feature/reload-banner-ad branch from 753d904 to 4527050 Compare May 20, 2024 19:08
@dylancom
Copy link
Collaborator Author

Thanks! I slightly refactored it so there is some code reusage and called it "load".

@dylancom dylancom merged commit 2a57487 into main May 21, 2024
7 of 11 checks passed
@dylancom dylancom deleted the feature/reload-banner-ad branch May 21, 2024 06:43
@mikehardy
Copy link
Collaborator

🎉 This PR is included in version 13.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants