Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): Fixed map the commands #590

Closed
wants to merge 1 commit into from
Closed

fix(android): Fixed map the commands #590

wants to merge 1 commit into from

Conversation

minhchienwikipedia
Copy link

@minhchienwikipedia minhchienwikipedia commented Jun 23, 2024

Description

Seems you guys missing to convert the commands from string to number, I just added changes to fix it and make some function triggers by command work.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide
    and followed the process outlined there for submitting PRs.
    • [ x] Yes
  • My change supports the following platforms;
    • [x ] Android
    • iOS
  • My change includes tests;
    • [ x] e2e tests added or updated in __tests__e2e__
    • [ x] jest tests added or updated in __tests__
  • [ ]x I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • [ x] Yes
    • No

Test Plan


Think react-native-google-mobile-ads is great? Please consider supporting the project with any of the below:

  • 👉 Star this repo on GitHub ⭐️
  • 👉 Follow Invertase on Twitter

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@minhchienwikipedia minhchienwikipedia changed the title Fix map command fix(android): Map command Jun 23, 2024
@minhchienwikipedia minhchienwikipedia changed the title fix(android): Map command fix(android): Fixed map the commands Jun 23, 2024
@dylancom
Copy link
Collaborator

dylancom commented Jun 27, 2024

The string is already parsed to an integer so I don't understand what this fixes.
Integer.parseInt(commandId)

This could be made redundant by changing the parameter directly to int commandId.

@minhchienwikipedia
Copy link
Author

@dylancom the commandId is "load", "recordManualImpression" -> so it can't be parseInt, you can try to test it you will get the error. So I think you guys are missing the map command string to the command number. I had tested it and it works for me

@dylancom
Copy link
Collaborator

Hmm I see it's broken now in our example app.
Might be related to the new arch.

@dylancom
Copy link
Collaborator

I'm currently on a holiday so I don't have time to test this thoroughly on both archs. @mikehardy / others? 👀

@dylancom
Copy link
Collaborator

dylancom commented Jul 4, 2024

Fixed it slightly differently, since we don't need the mapping of int to string anymore.
Thanks for the report.

@dylancom dylancom closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants