feat: gather consent method to make user consent easier #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/react-native-google-mobile-ads~654 Documentation is deployed and generated using docs.page. |
dylancom
force-pushed
the
feature/simplify-consent
branch
from
3b0a663 to
070db19
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
## [14.4.0](v14.3.1...v14.4.0) (2024-11-15) ### Features * gather consent method to make user consent easier ([#654](#654)) ([9a9e5e5](9a9e5e5))
|
🎉 This PR is included in version 14.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@dylancom gatherConsent's type is incorrect here. It should be: |
|
@ng-ha You're right. Thanks for mentioning it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While checking the official ios docs for changes I noticed that Google uses a helper method in their examples which I think can benefit this library too. Making it less cumbersome to show a consent form when necessary.
So you don't first have to call
requestInfoUpdateand thenloadAndShowConsentFormIfRequired.But just
gatherConsent.See: https://github.com/googleads/googleads-mobile-ios-examples/blob/043de5a21d5b529ded1fb845f9f8082d130113f8/Objective-C/admob/BannerExample/BannerExample/GoogleMobileAdsConsentManager.m#L45
And: https://developers.google.com/admob/ios/privacy#request-ads