Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing default requestagent #659

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

dylancom
Copy link
Collaborator

@dylancom dylancom commented Nov 23, 2024

Description

Default agent was never added to banner and in cases where no options where specified.
Fixes #658

Copy link

docs-page bot commented Nov 23, 2024

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/react-native-google-mobile-ads~659

Documentation is deployed and generated using docs.page.

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

@mikehardy mikehardy merged commit d56ac12 into main Nov 23, 2024
13 checks passed
@mikehardy mikehardy deleted the bugfix/default-request-agent-missing branch November 23, 2024 21:46
@mikehardy
Copy link
Collaborator

🎉 This PR is included in version 14.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate module banner ad source attribution
3 participants