feat(ios): UMP Consent on new arch #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/react-native-google-mobile-ads~667 Documentation is deployed and generated using docs.page. |
dylancom
force-pushed
the
feature/ump-on-new-arch
branch
from
764362a to
e16bb7b
Compare
dylancom
force-pushed
the
feature/ump-on-new-arch
branch
from
e546cf5 to
def14f4
Compare
mikehardy
reviewed
Dec 4, 2024
mikehardy
reviewed
Dec 4, 2024
mikehardy
approved these changes
Dec 4, 2024
Still async. But there is the possibility now to make some methods sync for new arch. Not sure what path we should take there, introduce new methods / breaking change? Send it back sync on the new arch, but wrap it in a promise for now... |
mikehardy
approved these changes
Dec 5, 2024
|
🎉 This PR is included in version 14.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UMP Consent on new arch
Note that importing types does (still) not work with codegen, so I moved the types to the spec directly.
Any folks that can test this? @TaylorDale @wjaykim @DoctorJohn @birdofpreyru