Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests #133

Merged
merged 8 commits into from
Dec 16, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ on:
branches:
- next
pull_request:
branches:
- next

jobs:
test:
Expand Down Expand Up @@ -32,7 +34,7 @@ jobs:
run: pnpm install

- name: Start Firebase Emulator Suite
uses: firebase-emulator-action@v1
uses: invertase/firebase-emulator-action@v1.0.1

# Determine which packages have changed
- name: Determine changed packages
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,6 @@ dist

functions/lib/**/*.js
functions/lib/**/*.js.map

# Firebase cache
.firebase/
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@ import {
type FirestoreError,
} from "firebase/firestore";

type FirestoreUseMutationOptions<TData = unknown, TError = Error> = Omit<
type UseFirestoreMutationOptions<TData = unknown, TError = Error> = Omit<
UseMutationOptions<TData, TError, void>,
"mutationFn"
>;

export function useClearIndexedDbPersistenceMutation(
firestore: Firestore,
options?: FirestoreUseMutationOptions<void, FirestoreError>
options?: UseFirestoreMutationOptions<void, FirestoreError>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made this change so as to have a change in the react package so that react tests are triggered to run.

) {
return useMutation<void, FirestoreError>({
...options,
Expand Down
1 change: 1 addition & 0 deletions vitest.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import path from "path";

export default defineConfig({
test: {
fileParallelism: false,
coverage: {
provider: "istanbul",
},
Expand Down