Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add din5008 header option #23

Merged
merged 12 commits into from
Jan 21, 2025
Merged

Add din5008 header option #23

merged 12 commits into from
Jan 21, 2025

Conversation

beliolfa
Copy link
Contributor

@beliolfa beliolfa commented Dec 4, 2024

No description provided.

@beliolfa beliolfa changed the title add din5008 header option Add din5008 header option Dec 4, 2024
@beliolfa beliolfa marked this pull request as draft December 4, 2024 10:40
Base automatically changed from verifactu_invoice to main December 17, 2024 16:22
samlown
samlown approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few observations, in general looks good!

components/bill/invoice/invoice.templ Outdated Show resolved Hide resolved
goblhtml.go Outdated Show resolved Hide resolved
@beliolfa beliolfa requested a review from samlown January 17, 2025 15:05
@beliolfa beliolfa marked this pull request as ready for review January 17, 2025 15:06
@beliolfa beliolfa merged commit 770ece8 into main Jan 21, 2025
4 checks passed
@beliolfa beliolfa deleted the din5008_header branch January 21, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlown samlown Awaiting requested review from samlown

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beliolfa @samlown