-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First import after refactor #2
Conversation
samlown
commented
Mar 15, 2023
•
edited by cavalle
Loading
edited by cavalle
- Related to https://github.com/invopop/ticketbai/pull/6
@samlown I just pushed my latest work on this refactor along with the related changes in https://github.com/invopop/ticketbai/pull/6. I delimited the scope to completing the extraction of the I suggest that you review these two PRs, provide any feedback you may have, we decide whether we should address it in these PRs or in subsequent ones, we merge and I continue with the other things we've identified (e.g. move from item keys extensions…) In summary, this PR doesn't aim to cover everything, just make progress in the right direction (hopefully!) |
Looking great @cavalle! And yes, getting the extensions to work with the exception cases would be a great next step. The README.md in that regard is quite out of date. |
Thanks @samlown! I've updated both READMEs, added a basic CLI and setup GH workflows. I'm merging this now. |