Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First import after refactor #2

Merged
merged 13 commits into from
Dec 8, 2023
Merged

First import after refactor #2

merged 13 commits into from
Dec 8, 2023

Conversation

samlown
Copy link
Contributor

@samlown samlown commented Mar 15, 2023

@cavalle
Copy link
Contributor

cavalle commented Dec 7, 2023

@samlown I just pushed my latest work on this refactor along with the related changes in https://github.com/invopop/ticketbai/pull/6.

I delimited the scope to completing the extraction of the gobl.ticketbai package, update to use the latest GOBL and make sure everything works. I tested locally and managed to issue invoices successfully in the Batuz test environment.

I suggest that you review these two PRs, provide any feedback you may have, we decide whether we should address it in these PRs or in subsequent ones, we merge and I continue with the other things we've identified (e.g. move from item keys extensions…)

In summary, this PR doesn't aim to cover everything, just make progress in the right direction (hopefully!)

@samlown
Copy link
Contributor Author

samlown commented Dec 7, 2023

Looking great @cavalle! And yes, getting the extensions to work with the exception cases would be a great next step. The README.md in that regard is quite out of date.

@cavalle
Copy link
Contributor

cavalle commented Dec 8, 2023

Thanks @samlown! I've updated both READMEs, added a basic CLI and setup GH workflows. I'm merging this now.

@cavalle cavalle marked this pull request as ready for review December 8, 2023 11:47
@cavalle cavalle merged commit c24504f into main Dec 8, 2023
2 checks passed
@cavalle cavalle deleted the refactor branch December 18, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants