Add mywallbox Adapter to latest

[SKB-CGN]

Adapter for Cloud based Wallboxes like Pulsar or Pulsar Plus

[Apollon77]

Hi, thank you for your adapter.

Is the adapter for Pulsar Wallboxes only? Then "Wallbox" as name is too generic in my eyes ... or do you pan to add more other such? Could you please rename it to pulsar-wallbox or such?

[SKB-CGN]

Hi, thank you for your adapter.

Is the adapter for Pulsar Wallboxes only? Then "Wallbox" as name is too generic in my eyes ... or do you pan to add more other such? Could you please rename it to pulsar-wallbox or such?

The Company is named "Wallbox" therefore i choosed this name.

[Apollon77]

wow ... puuhh ... a company name which matches a "in the meantime commodoty name of a device type" :-( I will discuss it in core team...
But I hope you also understand my point of view?

[SKB-CGN]

Sure, understand it. Never mind. They even own www.wallbox.com as their domain.
So its most common name for product and company ;)

Could you do the checks needed for the adapter in the meantime? Thanks beforehand!

[SKB-CGN]

Hi,
do we have some news here?

[Apollon77]

Yes, we discussed yesterday. WOuld it be an issue torename tzo "my-wallbox" so we match the name of that cloud servcie you connect to?

Additionally please state in the readme exactly that it is for Wallboxes from company "wallbox" or such ... right now also the Readme could be easiely read "works for all wallboxes". The same for io-package title/tileLang and desc fields please.

This is a special case, but we want to avoid user confusion.

Additionally please adjust the links in the repo file to use raw.githubusercontent.com like the others ... github.com is not a CDN service ...

Thnak you very much for your understanding and support on this

[SKB-CGN]

Hi,
would you please check the things again.

I have updated the name to My-Wallbox and changed (hopefully) all necessary dependencies and files.

Thank you!

[Apollon77]

I will do the adapter review in the next days ...

[SKB-CGN]

Great, but now i have the problem, that the adapter is not working anymore ... i do not know, whats going on.

[Apollon77]

Hm ... data on github looks fine ... what error you get?

[SKB-CGN]

The adapter is not doing anything. No commands running, no Interval is working. Nothing.

Even not able to change to debug to see some output.

[Apollon77]

Code wise looks good ... also github actionsstart tghe adapter ... how you test locally?

[SKB-CGN]

i created the adapter with adapter creator and everytime i change the code, i do iobroker upload mywallbox

[Apollon77]

but you also reinstalled the adapter after that namechange completely?

[SKB-CGN]

Holy bible. I missed an error-handling. Will fix that shortly.

[SKB-CGN]

Now its working again. Thanks for waiting.

[SKB-CGN]

@Apollon77 Do we have some news here? :)

[Apollon77]

Yes, after vacation, wasn't able to do it before

[SKB-CGN]

Can someone please tell me, how "ioBroker.my-wallbox" can be removed here? I needed to change the name and the check always goes through my-wallbox either instead of only using mywallbox.

Thank you!

[Apollon77]

All good ... the checker only checks the initial repo file change ... so clean would be new PR ... but in this case "known", so all fine

[SKB-CGN]

Ok and all things are good now?

[Apollon77]

Hi,
here my review comments:

• please sort in the entry in this PR alphabetically
• please fix that link https://github.com/SKB-CGN/ioBroker.mywallbox/blob/main/io-package.json#L131 (blob is too much)
• please also add an emoty "password" field in native https://github.com/SKB-CGN/ioBroker.mywallbox/blob/main/io-package.json#L151 as default value
• Please add a "common.globalDependencies with admin >= 4.0.9 to io-package because you use the automatic encryption
• you configured the automatic encryption but still have code in admin to encrypt passwords and to decrypt in main.js ... you you encrypt it twice right now ... Please remove https://github.com/SKB-CGN/ioBroker.mywallbox/blob/main/admin/index_m.html#L63 and the main.js code (would be breaking for all current users)
• Note: Using intervals for external server communication is not ideal (https://github.com/SKB-CGN/ioBroker.mywallbox/blob/d3e6a7543c1eb7ee85660d31b14672761cf4e28a/main.js#L444) ... can be done but could generate issues- seee infos in best practices
• you should set a timeout for the external communication which is always lower then your interval (or not use an interval at all - see above)
• Please check roles - e.g. https://github.com/SKB-CGN/ioBroker.mywallbox/blob/d3e6a7543c1eb7ee85660d31b14672761cf4e28a/main.js#L806 ... an indicator is defined as boolean red-only and not for numbers, see Role definitions in https://github.com/ioBroker/ioBroker/blob/master/doc/STATE_ROLES.md

Thank you for checking and adjusting,

Ingo

[mcm1957]

RE-CHECK!

[github-actions]

Automated adapter checker

blob

-

• ❗ [E000] FATAL: cannot access repository https://api.github.com/repos/SKB-CGN/ioBroker.wallbox/blob
• ❗ [E999] GLOBAL ERROR: AxiosError: Request failed with status code 404, {"message":"Request failed with status code 404","name":"AxiosError","stack":"AxiosError: Request failed with status code 404\n at settle (/home/runner/work/ioBroker.repositories/ioBroker.repositories/node_modules/axios/dist/node/axios.cjs:2019:12)\n at Unzip.handleStreamEnd (/home/runner/work/ioBroker.repositories/ioBroker.repositories/node_modules/axios/dist/node/axios.cjs:3135:11)\n at Unzip.emit (node:events:529:35)\n at endReadableNT (node:internal/streams/readable:1400:12)\n at process.processTicksAndRejections (node:internal/process/task_queues:82:21)\n at Axios.request (/home/runner/work/ioBroker.repositories/ioBroker.repositories/node_modules/axios/dist/node/axios.cjs:4287:41)\n at process.processTicksAndRejections (node:internal/process/task_queues:95:5)","config":{"transitional":{"silentJSONParsing":true,"forcedJSONParsing":true,"clarifyTimeoutError":false},"adapter":["xhr","http","fetch"],"transformRequest":[null],"transformResponse":[null],"timeout":0,"xsrfCookieName":"XSRF-TOKEN","xsrfHeaderName":"X-XSRF-TOKEN","maxContentLength":-1,"maxBodyLength":-1,"env":{},"headers":{"Cache-Control":"no-cache","Pragma":"no-cache","Expires":"0","User-Agent":"axios/1.7.7","Accept-Encoding":"gzip, compress, deflate, br"},"cache":false,"method":"get","url":"https://api.github.com/repos/SKB-CGN/ioBroker.wallbox/blob"},"code":"ERR_BAD_REQUEST","status":404}

ioBroker.my-wallbox

-

• ❗ [E020] Name of adapter in package.json must be lowercase and be equal to "iobroker.my-wallbox". Now is "iobroker.mywallbox"
• ❗ [E103] "common.name" in io-package.json must be equal to "my-wallbox'". Now is mywallbox
• ❗ [E251] Bluefox was not found in the collaborators on NPM!. Please execute in adapter directory: npm owner add bluefox iobroker.my-wallbox
• ❗ [E999] GLOBAL ERROR: TypeError: Cannot read properties of undefined (reading 'latest'), {}
• 👀 [W034] @iobroker/adapter-core 3.1.6 specified. 3.2.2 is recommended. Please consider updating dependencies at package.json

ioBroker.mywallbox

-

• ❗ [E254] Versions "0.0.17, 0.0.16" listed at common.news at io-package.json do not exist at NPM. Please remove from news section.
• 👀 [S522] Please consider migrating to admin 5 UI (jsonConfig).
• 👀 [S526] Consider adding plugin "@alcalzone/release-script-plugin-manual-review".
• 👀 [W034] @iobroker/adapter-core 3.1.6 specified. 3.2.2 is recommended. Please consider updating dependencies at package.json
• 👀 [W401] Cannot find "mywallbox" in latest repository

Add comment "RE-CHECK!" to start check anew

[SKB-CGN]

RE-CHECK!

[github-actions]

Automated adapter checker

blob

-

• ❗ [E000] FATAL: cannot access repository https://api.github.com/repos/SKB-CGN/ioBroker.wallbox/blob
• ❗ [E999] GLOBAL ERROR: AxiosError: Request failed with status code 404, {"message":"Request failed with status code 404","name":"AxiosError","stack":"AxiosError: Request failed with status code 404\n at settle (/home/runner/work/ioBroker.repositories/ioBroker.repositories/node_modules/axios/dist/node/axios.cjs:2019:12)\n at Unzip.handleStreamEnd (/home/runner/work/ioBroker.repositories/ioBroker.repositories/node_modules/axios/dist/node/axios.cjs:3135:11)\n at Unzip.emit (node:events:529:35)\n at endReadableNT (node:internal/streams/readable:1400:12)\n at process.processTicksAndRejections (node:internal/process/task_queues:82:21)\n at Axios.request (/home/runner/work/ioBroker.repositories/ioBroker.repositories/node_modules/axios/dist/node/axios.cjs:4287:41)\n at process.processTicksAndRejections (node:internal/process/task_queues:95:5)","config":{"transitional":{"silentJSONParsing":true,"forcedJSONParsing":true,"clarifyTimeoutError":false},"adapter":["xhr","http","fetch"],"transformRequest":[null],"transformResponse":[null],"timeout":0,"xsrfCookieName":"XSRF-TOKEN","xsrfHeaderName":"X-XSRF-TOKEN","maxContentLength":-1,"maxBodyLength":-1,"env":{},"headers":{"Cache-Control":"no-cache","Pragma":"no-cache","Expires":"0","User-Agent":"axios/1.7.7","Accept-Encoding":"gzip, compress, deflate, br"},"cache":false,"method":"get","url":"https://api.github.com/repos/SKB-CGN/ioBroker.wallbox/blob"},"code":"ERR_BAD_REQUEST","status":404}

ioBroker.my-wallbox

-

• ❗ [E020] Name of adapter in package.json must be lowercase and be equal to "iobroker.my-wallbox". Now is "iobroker.mywallbox"
• ❗ [E103] "common.name" in io-package.json must be equal to "my-wallbox'". Now is mywallbox
• ❗ [E251] Bluefox was not found in the collaborators on NPM!. Please execute in adapter directory: npm owner add bluefox iobroker.my-wallbox
• ❗ [E999] GLOBAL ERROR: TypeError: Cannot read properties of undefined (reading 'latest'), {}

ioBroker.mywallbox

-

👍 No errors found

• 👀 [S522] Please consider migrating to admin 5 UI (jsonConfig).
• 👀 [S526] Consider adding plugin "@alcalzone/release-script-plugin-manual-review".
• 👀 [W401] Cannot find "mywallbox" in latest repository

Add comment "RE-CHECK!" to start check anew

[SKB-CGN]

@mcm1957 As all errors have been fixed, can we proceed?

[mcm1957]

Yes i wll do as soon as I find time.
Have some backlog due to travel to Solingen (Meeting) and back.
Sorry.

[SKB-CGN]

Not a problem ;)
Take your time!

[github-actions]

ioBroker repository information about New at LATEST tagging

• Please ignore this comment at 'old' PRs.

[mcm1957]

@SKB-CGN

First of all - THANK YOU for the time and effort you spend to maintain this adapter.

I'm sorry, that I did not check this adapter for such a long time - I simpyl do not have enough spare time.

Thanks for fixing issues already listed by Apollon77 and adapter checker. I do not remeber to have scanned this adapter in the past so I did a full recheck. Sorry to say that I would like to note some MINOR remarks. I think they should be fixable with small effort. Please take a look and do not spent time for eslint - this last point is only a hint for the future and not related to release for latest.

Thanks
mcm1957

---

• folder ./lib contains unrelated files

  The folder ./lib contains several fiels copied from ioBroker.repositories. They do not make sense there. Please delete them (I think all but states.js are incorrect)

• creation of state tree seems to be incomplete

  You are creating some states with a dot in their name, i.e. 'lock.auto_lock'. This creates a tree consisting of an folder named lock and a state below named auto_lock. I could not detect the place where the (folder) Object 'lock' is created. Please note that all levels ob objects (device, channel, folders, states) must be explicitly created. Missing to create intermediate levels might be considered an error in furure versions of js-controller.

  As you seem to have fixed states only, it would be fully sufficient to liste the folders / channels (and even the states) at io-package. See existing creation of info and info.connection state.

• small note to state roles

  Only the values specified here (https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/stateroles.md) may be used as state roles. Do not invent new names as this might disturb the functionalyity of other adapters or vis.

  In addition the roles MUST match the read/write functionality. As an example a role value.* requires that the state is a readable state. Input states (write only) should have roles like level.*. Please read the description carefully. States with role 'button' should (must) have attribute 'common.read=false' set. A button ( "Taster" in german only triggers when you press but else has no state), so it should also be not readable. This is also like HomeMatic does it. A switch has clear states true or false and so can be read.

  Please avoid using general roles (state, value) whenever a dedicated role exists.

  State 'locked' must not have role 'indicator' if it is writeable. So either (suggestion) use role 'switch' or disable writeing the state - whatever matches the functionality. (https://github.com/SKB-CGN/ioBroker.mywallbox/blob/3c8d70edebf1902f658aa918aea6a8318badc882/lib/states.js#L413)

  Input states (i.e. maxChargingCurrent) must not have role value.* (as this is read only) but level.* - https://github.com/SKB-CGN/ioBroker.mywallbox/blob/3c8d70edebf1902f658aa918aea6a8318badc882/lib/states.js#L435

• A hint for migration of EsLint (not blocking remark)

  If you plan to migrate EsLint from 8.x.x to current release 9.x.x please migrate to use @iobroker/eslint-config. This is a new central configurarion of eslint-rules which should be used for all (new) adapters. But its not mandatory. A migration / installation guide is can be found here:

https://github.com/ioBroker/ioBroker.eslint-config/blob/main/MIGRATION.md

Thanks for reading and evaluating this suggestions.
McM1957

Please add a comment when you have reviewed and fixed the suggestionsor at least commented the suggestions and you think the adapter is ready for a re-review!

reminder 1.12.2024

[SKB-CGN]

Hi,
may i ask you, to check this again, please?

I didnt find out, to state "normal" seconds state - is it possible, to use "value.interval" for this?
It displays a total charging time - which is in seconds.

[mcm1957]

I do not see a normal "seconds" state for timing too. You may use value.intervall - although its no true interval - or simüly use value as role.

In general it looks like all issues are satisifed. I'll rekease the adapter to stable now.

THANKS a lot for your work.

[mcm1957]

This adapter has been released to latest repository and should be visible within 24h maximum.

Please create a thread at https://forum.iobroker.net/category/91/tester titled like "Test Adapter " to collect some user feedback and provide a link to this topic when requesting addition to stable repository later.

Note: If an other testing topic already exists, it' OK to continue using this topic too.