added handling of Total Active Energy data to addEM1 function for shellyproem50 #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klein0r
reviewed
Jan 18, 2025
| common: { | ||
| name: 'Total Energy', | ||
| type: 'number', | ||
| role: 'value.total_energy', |
| @@ -115,6 +115,22 @@ function addEM1(deviceObj, switchId) { | |||
| unit: 'Hz', | |||
| }, | |||
| }; | |||
| deviceObj[`EM1:${switchId}.TotalEnergy`] = { | |||
|
Valid state roles are listed here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Change adds support for handling total active energy of the shellyproem50. Until this change the Energy Meter Data sent by this device where ignored and no Datapoint where created or updated as described in issue #1070 which should be solved with this code. I was able to prove this in my local installation.
While the addEM1 function was only used by the gen2/shellyproem50.js -device I added the handler just there.
I would be happy if you would integrate this code to the main-project.
While this is my first pull request I ever sent, I'm not sure, if I did anything what should be done. So, feedback is welcome.
Regards
tclas