Don't rerun checkers needlessly #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the file 'checker-log.txt' was overwritten each time a checker was run. That meant that the checker often needed to be rerun needlessly (as the file was lost). We now simply capture the standard output and save it in the '.rules' directory. We only allow CPPPrograms as checkers.
t-lenz
approved these changes
Apr 17, 2022
There was a problem hiding this comment.
This looks good on the checker/constraints side. Only a couple of very minor points:
- There's a typo in
TaskConfig.py(see the respective comment) - You should update the dates in the “copyright” section of the respective files
- We should mention in the docs that checkers (a) must be written in C++ and (b) must not write anything to standard output.
Maybe also someone else who's familiar with the rules system should have a look at this, for example @magula.
| try: | ||
| checker_log = "checker-log.txt" | ||
| if not isinstance(checker, CPPProgram): | ||
| raise Exception("Only checkers written in c++ are allowed.") |
|
Thanks! I've fixed the issues you pointed out. |
magula
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #20 (comment) using solution proposal 1.
It only allows checkers written in C++, but I guess that was already assumed before. (?)
@t-lenz Please let me know if this looks okay.