fix(datetime): allow accurate typing of time values in 24-hour format #30147
+121
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adjusted the `selectMultiColumn` logic to handle keyboard values like 20 and 22 dynamically. - Introduced checks for the maximum column value to enable flexible input behavior. - Added e2e tests to verify correct value selection for both 12-hour and 24-hour formats. Closes ionic-team#28877
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
OS-pedrolourenco
requested review from
brandyscarney
and removed request for
OS-pedrolourenco
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selectMultiColumnlogic to handle keyboard values like 20 and 22 dynamically.Issue number: resolves #28877
What is the current behavior?
In the ion-datetime component, when typing 2000 in the keyboard the resulted time value is 02:00 (in 24-hour format)
Examples: https://forum.ionicframework.com/t/ion-datetime-disable-opening-keyboard/224558/6?u=dennisskylegs
What is the new behavior?
In the ion-datetime component, when typing 2000 in the keyboard the resulted time value is 20:00 (in 24-hour format)
Does this introduce a breaking change?