Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): add required prop #30155

Merged
merged 9 commits into from
Feb 4, 2025
Merged

Conversation

OS-giulianasilva
Copy link
Contributor

@OS-giulianasilva OS-giulianasilva commented Jan 24, 2025

Issue number: resolves internal


What is the current behavior?

  • Currently, the screen reader do not announce the component as required when required={true}.

What is the new behavior?

  • Added a new required prop to be used for accessibility purposes that adds the aria-required attribute to select's inner native button.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@OS-giulianasilva OS-giulianasilva requested a review from a team as a code owner January 24, 2025 12:28
@github-actions github-actions bot added package: core @ionic/core package package: angular @ionic/angular package package: vue @ionic/vue package labels Jan 24, 2025
Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 10:03am

@OS-giulianasilva OS-giulianasilva changed the base branch from main to feature-8.5 January 24, 2025 18:10
@thetaPC thetaPC requested a review from brandyscarney January 30, 2025 16:04
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with VoiceOver

@OS-giulianasilva OS-giulianasilva merged commit 0b54983 into feature-8.5 Feb 4, 2025
47 checks passed
@OS-giulianasilva OS-giulianasilva deleted the ROU-11112-select branch February 4, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants