Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): update Stencil Vue output target #30159

Merged
merged 5 commits into from
Jan 29, 2025
Merged

fix(vue): update Stencil Vue output target #30159

merged 5 commits into from
Jan 29, 2025

Conversation

christian-bromann
Copy link
Member

This patch includes some necessary updates for @stencil/[email protected]:

  • we started to export Stencils helpers as runtime via @stencil/vue-output-target/runtime similar to what we did in React
  • this version requires some updates to Vue and TypeScript as well
  • adjustments related to that update

@christian-bromann christian-bromann requested a review from a team as a code owner January 25, 2025 00:06
Copy link

vercel bot commented Jan 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 2:05am

@github-actions github-actions bot added package: angular @ionic/angular package package: vue @ionic/vue package labels Jan 25, 2025
@christian-bromann christian-bromann changed the title fix(vue): Stencil Vue update fix(vue): stencil Vue update Jan 25, 2025
"@rollup/plugin-typescript": "^11.1.5",
"@stencil/vue-output-target": "0.9.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be here when we have it here:

"@stencil/vue-output-target": "^0.9.0",

We don't do this for any of the other frameworks:

"devDependencies": {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be here when we have it here:

Yes, starting with v0.9.0 we are shipping the Vue runtime as part of the package (see import { defineContainer } from '@stencil/vue-output-target/runtime'; in here). Since this code will be bundled with Rollup, we are ok keeping it as dev dependencies so for the Ionic user, nothing changes.

We don't do this for any of the other frameworks:

We will have to do the same once we update React. Angular doesn't ship a runtime export.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info! Sounds good.

@brandyscarney brandyscarney changed the title fix(vue): stencil Vue update fix(vue): update stencil Vue output target Jan 29, 2025
@brandyscarney brandyscarney changed the title fix(vue): update stencil Vue output target fix(vue): update Stencil Vue output target Jan 29, 2025
@brandyscarney brandyscarney added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit eb725fc Jan 29, 2025
61 checks passed
@brandyscarney brandyscarney deleted the cb/vue-update branch January 29, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants