-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vue): update Stencil Vue output target #30159
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
"@rollup/plugin-typescript": "^11.1.5", | ||
"@stencil/vue-output-target": "0.9.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be here when we have it here:
ionic-framework/core/package.json
Line 53 in 0030be8
"@stencil/vue-output-target": "^0.9.0", |
We don't do this for any of the other frameworks:
"devDependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be here when we have it here:
Yes, starting with v0.9.0
we are shipping the Vue runtime as part of the package (see import { defineContainer } from '@stencil/vue-output-target/runtime';
in here). Since this code will be bundled with Rollup, we are ok keeping it as dev dependencies so for the Ionic user, nothing changes.
We don't do this for any of the other frameworks:
We will have to do the same once we update React. Angular doesn't ship a runtime export.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the info! Sounds good.
This patch includes some necessary updates for
@stencil/[email protected]
:@stencil/vue-output-target/runtime
similar to what we did in React