Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android): handle INSTALL_FAILED_OLDER_SDK adb error #92

Merged
merged 1 commit into from
Dec 2, 2019
Merged

feat(android): handle INSTALL_FAILED_OLDER_SDK adb error #92

merged 1 commit into from
Dec 2, 2019

Conversation

SchnWalter
Copy link
Contributor

@SchnWalter SchnWalter commented Nov 28, 2019 •
edited
Loading

Related to #89; the linked issue is more generic, this is just a small fix for handling the ADB error when trying to install onto a device that doesn't meet the minSdkVersion requirement.

cc: @dwieeb

@imhoffd
Copy link
Contributor

imhoffd commented Dec 2, 2019

This looks great! 👍

@imhoffd imhoffd merged commit 6616f37 into ionic-team:master Dec 2, 2019
Ionitron added a commit that referenced this pull request Dec 4, 2019
@Ionitron
chore(release): 0.3.0 [skip ci]
8e9c7bf 
# [0.3.0](v0.2.9...v0.3.0) (2019-12-04)

### Features

* **android:** handle INSTALL_FAILED_OLDER_SDK adb error ([#92](#92)) ([6616f37](6616f37))
* **android:** support API 29 ([2282b3a](2282b3a))
@Ionitron
Copy link
Collaborator

Ionitron commented Dec 4, 2019

🎉 This PR is included in version 0.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SchnWalter SchnWalter deleted the handle-install-failed-older-sdk-adb-error branch January 7, 2020 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SchnWalter @imhoffd @Ionitron