generated from crossplane/provider-template
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add sset creation test for harder paths #219
Open
cristiGuranIonos
wants to merge
4
commits into
feat/serverset_ctrl
Choose a base branch
from
feat/add_serverset_creation_test
base: feat/serverset_ctrl
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
test: add sset creation test for harder paths #219
cristiGuranIonos
wants to merge
4
commits into
feat/serverset_ctrl
from
feat/add_serverset_creation_test
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal/controller/serverset/serverset_crossplane_mock_test.go
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
fghimpeteanu-ionos
approved these changes
May 24, 2024
fghimpeteanu-ionos
requested changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The unit test are failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds:
Checklist
I have:
feat
/fix
/doc
/test
/refactor
)make reviewable
andmake crds.clean
to ensure the PR is ready for reviewmake docs.update
(if applicable)docs/CHANGELOG.md
file (label:upcoming release
)