New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/s3 management #676

Draft

rmocanu-ionos wants to merge 22 commits into master from feat/s3-management

Contributor

rmocanu-ionos commented Sep 24, 2024

What does this fix or implement?

Checklist

PR name added as appropriate (e.g. feat:/fix:/doc:/test:/refactor:)
Tests added or updated
Documentation updated
Changelog updated and version incremented (label: upcoming release)
Github Issue linked if any
Jira task updated

rmocanu-ionos added 9 commits

September 17, 2024 16:21


          feat: added accessKeys resource

a79edee


          fixed some plugin framework compatibilities

d84c3c2


          feat: added data sources, some refactoring

456d7ba


          fix: working data sources, use valueString and other fixes

80e997c


          fix: getting version and terraform version like in the old provider

583b17b


          fix: rename bucket references

2a093e2


          doc: added docs

61003e9


          test: added tests wip, renamed files


          test: fix tests

a5f0fea

digna-ionos reviewed

View reviewed changes

internal/framework/provider/provider.go Outdated Show resolved Hide resolved

digna-ionos reviewed

View reviewed changes

internal/framework/services/s3management/data_source_s3_accesskey.go Outdated Show resolved Hide resolved

digna-ionos reviewed

View reviewed changes

internal/framework/services/s3management/data_source_s3_accesskey.go Outdated Show resolved Hide resolved

digna-ionos reviewed

View reviewed changes

internal/framework/services/s3management/data_source_s3_region.go Outdated Show resolved Hide resolved

digna-ionos reviewed

View reviewed changes

internal/framework/services/s3management/resource_s3_accesskey.go Show resolved Hide resolved

digna-ionos reviewed

View reviewed changes

internal/framework/services/s3management/resource_s3_accesskey_test.go Outdated Show resolved Hide resolved

digna-ionos reviewed

View reviewed changes

services/s3management/accesskeys.go Show resolved Hide resolved

digna-ionos reviewed

View reviewed changes

services/s3management/accesskeys.go Outdated Show resolved Hide resolved

digna-ionos reviewed

View reviewed changes

services/s3management/accesskeys.go Outdated Show resolved Hide resolved

digna-ionos reviewed

View reviewed changes

services/s3management/accesskeys.go Outdated Show resolved Hide resolved

digna-ionos reviewed

View reviewed changes

services/s3management/accesskeys.go Show resolved Hide resolved

digna-ionos reviewed

View reviewed changes

services/s3management/accesskeys.go Show resolved Hide resolved

rmocanu-ionos added 8 commits

September 27, 2024 13:39


          fix: get specific client from bundle, added some checks to tests

466c487


          fix: check for err and return if not nil to reduce complexity

4b51cbf


          doc: added comments

57dd3aa


          fix: made s3 work with sdk bundle

554bf1e


          refactor: move cloudapi client initialization in method, sonar fixes


          doc: added comments

e28f281


          Merge branch 'master' into feat/s3-management

51b16c0


          sonar fixes

19f2115

Contributor

digna-ionos commented Sep 27, 2024

LGTM. Just fix the lint issues. Nice job 🚀

rmocanu-ionos added 5 commits

September 30, 2024 15:36


          added the sdk to run linter

51920f0


          fix: linter issues

361e152


          fix: linter issues 2

ec42e76


          fix: try fix imports

57473b1


          fix: try fix imports 2

f98abc7

sonarcloud bot commented Sep 30, 2024

Quality Gate passed

Issues
0 New issues
5 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.6% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet