Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ioos_btn_metrics.csv #103

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Update ioos_btn_metrics.csv #103

merged 1 commit into from
Jan 29, 2025

Conversation

MathewBiddle
Copy link
Contributor

closes #99

@MathewBiddle
Copy link
Contributor Author

The test failed, but I don't think it's because the update to the csv is bad. I think pkg_resources has been deprecated?

=============================== warnings summary ===============================
tests/test_metrics.py::test_if_metric_is_a_natural_number
  /home/runner/micromamba/envs/TEST/lib/python3.13/site-packages/ckanapi/version.py:1: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
    import pkg_resources

https://github.com/ioos/ioos_metrics/actions/runs/13012445577/job/36293199101?pr=103#step:4:72

@ocefpaf
Copy link
Member

ocefpaf commented Jan 28, 2025

The test failed, but I don't think it's because the update to the csv is bad. I think pkg_resources has been deprecated?

That is just a warning. And it is in a downstream library, just ignore it.

The real failure is above in the log. The test_ngdac_gliders_fast is failing with a 503. It is likely that the server blocked the request and/or is under maintenance. Let's restart the tests later just to be sure.

@MathewBiddle
Copy link
Contributor Author

Test no longer fails! Merging.

@MathewBiddle MathewBiddle merged commit 6d44cbf into main Jan 29, 2025
4 checks passed
@ocefpaf ocefpaf deleted the MathewBiddle-patch-1 branch January 29, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collate 2025 IOOS by the numbers
2 participants