Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for %-encoded characters in did_url #1301

Closed
wants to merge 1 commit into from

Conversation

UMR1352
Copy link
Contributor

@UMR1352 UMR1352 commented Feb 12, 2024

Description of change

The did_url crate doesn't support %-encoded characters. We add this functionality through our fork.

Links to any relevant issues

Fixes issue #1299.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Ran all tests and examples to assure they still work.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@UMR1352 UMR1352 added Bug Something isn't working. Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Feb 12, 2024
@UMR1352 UMR1352 self-assigned this Feb 12, 2024
@UMR1352 UMR1352 requested a review from a team as a code owner February 12, 2024 15:51
@UMR1352 UMR1352 added the Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog label Feb 12, 2024
@UMR1352 UMR1352 closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working. Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog.
Projects
Development

Successfully merging this pull request may close these issues.

1 participant