Skip to content

Apply a workaround to solve slow reading from GRPC.

Sign in for the full log view
GitHub Actions / golangci failed Dec 1, 2023 in 0s

reviewdog [golangci] report

reported by reviewdog 🐶

Findings (3)

components/faucet/component.go|310 col 43| Error return value of deps.Faucet.ApplyAcceptedTransaction is not checked (errcheck)
components/faucet/component.go|314 col 4| commentFormatting: put a space between // and comment text (gocritic)
components/faucet/component.go|309| components/faucet/component.go:309: Line contains TODO/BUG/FIXME: "TODO: replace this workaround for slow r..." (godox)

Filtered Findings (0)

Annotations

Check failure on line 310 in components/faucet/component.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] components/faucet/component.go#L310

Error return value of `deps.Faucet.ApplyAcceptedTransaction` is not checked (errcheck)
Raw output
components/faucet/component.go:310:43: Error return value of `deps.Faucet.ApplyAcceptedTransaction` is not checked (errcheck)
			go deps.Faucet.ApplyAcceptedTransaction(createdOutputs, consumedOutputs)
			                                       ^

Check failure on line 314 in components/faucet/component.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] components/faucet/component.go#L314

commentFormatting: put a space between `//` and comment text (gocritic)
Raw output
components/faucet/component.go:314:4: commentFormatting: put a space between `//` and comment text (gocritic)
			//err := deps.Faucet.ApplyAcceptedTransaction(createdOutputs, consumedOutputs)
			^

Check failure on line 309 in components/faucet/component.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] components/faucet/component.go#L309

components/faucet/component.go:309: Line contains TODO/BUG/FIXME: "TODO: replace this workaround for slow r..." (godox)
Raw output
components/faucet/component.go:309: components/faucet/component.go:309: Line contains TODO/BUG/FIXME: "TODO: replace this workaround for slow r..." (godox)
			// TODO: replace this workaround for slow reading with a proper solution