New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single account wallet #1279

Merged

thibault-martinez merged 116 commits into iotaledger:2.0 from Alex6323:refactor/wallet-account

Nov 1, 2023

Contributor

Alex6323 commented Sep 21, 2023 •

edited

Loading

Description of change

Removes separate account functionality from the wallet (now: 1 wallet == 1 account)
Transitions to a single address per wallet/account
Optional Secret Manager
Optional BIP44 path
Optional Wallet Alias

Bindings will be updated separately (and can be done in parallel). That's why they are temporarily excluded from the workspace.

Links to any relevant issues

Closes #1250


          start impl

48a698d

Thoralf-M reviewed

View reviewed changes

sdk/src/wallet/core/operations/verify_integrity.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/src/wallet/core/operations/stronghold_backup/mod.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/src/wallet/core/operations/get_account.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/src/wallet/core/operations/account_recovery.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/src/wallet/core/operations/account_recovery.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/src/wallet/core/mod.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/src/wallet/core/mod.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/src/wallet/core/mod.rs Outdated Show resolved Hide resolved


          walk the line 1

cfb6589

Thoralf-M reviewed

View reviewed changes

sdk/src/wallet/core/operations/account_recovery.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/src/wallet/core/operations/get_account.rs Outdated Show resolved Hide resolved

Alex6323 added 2 commits

September 21, 2023 18:49


          walk the line 2

cc2bb0c


          walk the line 3

ec94415

Thoralf-M reviewed

View reviewed changes

sdk/src/wallet/account/operations/address_generation.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/src/wallet/account/operations/syncing/addresses/mod.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/src/wallet/core/builder.rs Outdated Show resolved Hide resolved

Alex6323 added 7 commits

September 25, 2023 20:19


          update examples


          update tests

03a5844


          more

91c83e8


          update cli

adc2965


          update wallet builder

75c6f11


          remove redundant event wrapper

6d7d282


          fix remaining todos 1

088281f

Thoralf-M reviewed

View reviewed changes

sdk/src/wallet/account/operations/transaction/prepare_transaction.rs Outdated Show resolved Hide resolved

Alex6323 added 5 commits

September 27, 2023 14:25


          fix remaining todos 2

199a6fe


          fix remaining todos 3

e1aa5e9


          fix remaining todos 4

402e4a9


          Merge branch '2.0' into refactor/wallet-account

250500d


          clean up cli

62029f5

DaughterOfMars reviewed

View reviewed changes

sdk/src/wallet/operations/transaction/prepare_transaction.rs Outdated Show resolved Hide resolved

thibault-martinez added 5 commits

November 1, 2023 14:18


          More changes

ae20ba2


          Merge branch '2.0' into refactor/wallet-account

9446b12


          Comment failing tests

d4cba3f

Nit

73ecd7e


          More nits

c2d32cf

Thoralf-M reviewed

View reviewed changes

sdk/src/wallet/core/operations/background_syncing.rs Outdated Show resolved Hide resolved

thibault-martinez and others added 13 commits

November 1, 2023 18:55


          Update sdk/src/wallet/core/operations/background_syncing.rs

b958150

Co-authored-by: Thoralf-M <[email protected]>


          Merge branch '2.0' into refactor/wallet-account

70a3b38


          Fix a test

619e8b1


          Bring back assert

c691b2c


          Fix response type

80addf9


          Fix another response type

c0ea729


          Remove useless added inner() calls

c481880


          Bring back faucet address


          Fix comment

c2da899


          Not need to use format

85a116e


          TODO

860f4ff


          update_after_sync

3a0752a


          Fix log

9565d7a

DaughterOfMars previously approved these changes

View reviewed changes


          TODO

a21a32d

thibault-martinez dismissed DaughterOfMars’s stale review via

a21a32d

November 1, 2023 21:31


          Improve comment?

c42b8d8

Thoralf-M approved these changes

View reviewed changes

thibault-martinez approved these changes

View reviewed changes

thibault-martinez merged commit 0b1ef16 into iotaledger:2.0

21 of 35 checks passed

thibault-martinez mentioned this pull request

Merge Wallet and Account types #1250

Closed

Alex6323 deleted the refactor/wallet-account branch

November 2, 2023 08:16

Alex6323 mentioned this pull request

Accounts removal questions and TODOs #1521

Closed

20 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet