feat(iota-genesis-builder): Allow Shimmer test outputs generation #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miker83z
added
the
sc-platform
Thoralf-M
reviewed
Aug 8, 2024
crates/iota-genesis-builder/examples/snapshot_add_test_outputs.rs
Outdated
Show resolved
Hide resolved
Thoralf-M
reviewed
Aug 8, 2024
crates/iota-genesis-builder/src/stardust/test_outputs/vesting_schedule_portfolio_mix.rs
Outdated
Show resolved
Hide resolved
crates/iota-genesis-builder/examples/snapshot_add_test_outputs.rs
Outdated
Show resolved
Hide resolved
Thoralf-M
approved these changes
Aug 9, 2024
| pub(crate) async fn outputs(rng: &mut StdRng) -> anyhow::Result<Vec<(OutputHeader, Output)>> { | ||
| pub(crate) async fn outputs( | ||
| rng: &mut StdRng, | ||
| coin_type: u32, |
There was a problem hiding this comment.
Maybe use an enum?
There was a problem hiding this comment.
It was with the enum before! Pls check this comment.
There was a problem hiding this comment.
This is private testing code, I think it's fair to avoid unnecessary code duplication here
There was a problem hiding this comment.
tbh I think that was a bad change
There was a problem hiding this comment.
I disagree, but as I've said in the original comment, I'm not super strongly opinionated, up to Mirko.
There was a problem hiding this comment.
This is private testing code
I think this reply is enough 😄
thibault-martinez
approved these changes
Aug 13, 2024
|
@kodemartin pls merge it when you'll come back, if something should be changed maybe @Thoralf-M or @valeriyr could help you! 😄 🏖️ |
kodemartin
approved these changes
Aug 14, 2024
bingyanglin
pushed a commit
that referenced
this pull request
Aug 19, 2024
) * feat(iota-genesis-builder): allow shimmer test outputs generation * fix(iota-genesis-builder): adapt the other example * fix(iota-genesis-builder): differentiate between shimmer and iota coin type * fix(iota-genesis-builder): use u32 instead of CoinType * fix(iota-genesis-builder): fix example about * fix(iota-genesis-builder): storage deposit amounts (#1811) --------- Co-authored-by: Thibault Martinez <[email protected]>
alexsporn
pushed a commit
that referenced
this pull request
Sep 6, 2024
) * feat(iota-genesis-builder): allow shimmer test outputs generation * fix(iota-genesis-builder): adapt the other example * fix(iota-genesis-builder): differentiate between shimmer and iota coin type * fix(iota-genesis-builder): use u32 instead of CoinType * fix(iota-genesis-builder): fix example about * fix(iota-genesis-builder): storage deposit amounts (#1811) --------- Co-authored-by: Thibault Martinez <[email protected]>
alexsporn
pushed a commit
that referenced
this pull request
Sep 6, 2024
) * feat(iota-genesis-builder): allow shimmer test outputs generation * fix(iota-genesis-builder): adapt the other example * fix(iota-genesis-builder): differentiate between shimmer and iota coin type * fix(iota-genesis-builder): use u32 instead of CoinType * fix(iota-genesis-builder): fix example about * fix(iota-genesis-builder): storage deposit amounts (#1811) --------- Co-authored-by: Thibault Martinez <[email protected]>
alexsporn
pushed a commit
that referenced
this pull request
Sep 6, 2024
) * feat(iota-genesis-builder): allow shimmer test outputs generation * fix(iota-genesis-builder): adapt the other example * fix(iota-genesis-builder): differentiate between shimmer and iota coin type * fix(iota-genesis-builder): use u32 instead of CoinType * fix(iota-genesis-builder): fix example about * fix(iota-genesis-builder): storage deposit amounts (#1811) --------- Co-authored-by: Thibault Martinez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR allows to generate a test output snapshot starting from a Shimmer Hornet snapshot.
The generated test output snapshot includes addresses derived with the network coin type (IOTA or Shimmer) and uses the correct network total supply. After this changes, then, it is possible to produce Hornet snapshots containing test outputs able to be given as input to the Move objects snapshot generation script for generating Shimmer and IOTA snapshots.
Links to any relevant issues
Fixes #1660
Type of change
How the change has been tested
cargo run --release --example snapshot_only_test_outputs --features="test-outputs" -- iota --snapshot-path ../latest-full_snapshot-iota.bincargo run --release --bin iota-genesis-builder -- --disable-global-snapshot-verification iota --snapshot-path ../test-latest-full_snapshot-iota.bin --target-network alphanet-testcargo run --release --example snapshot_only_test_outputs --features="test-outputs" -- shimmer --snapshot-path ../latest-full_snapshot-shimmer.bincargo run --release --bin iota-genesis-builder -- --disable-global-snapshot-verification shimmer --snapshot-path ../test-latest-full_snapshot-shimmer.bin --target-network alphanet-testtarget/release/iota genesis --working-dir ../test_iota_config -f --with-faucet --num-validators 4 --local-migration-snapshots ./stardust_object_snapshot-iota.bin ./stardust_object_snapshot-shimmer.binChange checklist