Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Github Actions? #105

Closed
dalehamel opened this issue Feb 15, 2020 · 7 comments
Closed

RFC: Github Actions? #105

dalehamel opened this issue Feb 15, 2020 · 7 comments

Comments

@dalehamel
Copy link
Member

Github actions is now available and its been enabled for the iovisor github org.

Someone with admin access to this repo can add the QUAY_TOKEN to it like what is been done with travis.

The major advantage of actions over travis that I see are:

  • Travis.org seems to be getting aged-out for travis.com
  • Github actions offers much more concurrency (up to 20 jobs), so we could test kubectl trace maybe against different versions of k8s, and distros?

WDYT @leodido @fntlnz

@dalehamel dalehamel changed the title RFT: Github Actions? RFC: Github Actions? Feb 15, 2020
@leodido
Copy link
Member

leodido commented Feb 15, 2020

Total +1 from me.

Let's wait for @fntlnz's opinion (but I suppose he will be +1 too) :)

@leodido
Copy link
Member

leodido commented Feb 15, 2020

BTW I can work on it since I'd like to play a bit with GH actions finally :)

@dalehamel
Copy link
Member Author

BTW I can work on it since I'd like to play a bit with GH actions finally :)

Awesome! I added it to iovisor/bcc and iovisor/bpftrace, so you can check out those workflow files as a starting point. Some things are a little unituitive (eg, checkout action isn't default like on travis), but it's just as flexible as travis I think, and IMO a little nicer.

There is an SSH action you can use to ssh in and debug, which I gotta admin I really love.

We can also automate release actions on tags I think too, so could probable automate the process in docs/release.md to trigger when there is a tagged release?

@dalehamel
Copy link
Member Author

to add the QUAY_TOKEN we need someone with more privs in the iovisor org

@leodido
Copy link
Member

leodido commented Feb 15, 2020

to add the QUAY_TOKEN we need someone with more privs in the iovisor org

Yup, I know

Thanks for all this idea and all the suggestions, btw :)

@alban
Copy link
Contributor

alban commented Feb 15, 2020

I have a Github action in Inspektor Gadget here to build a new container image, push it to a container registry, and build the CLI with that exact image reference, so that the artifact could be downloaded on one's laptop and just try it without fearing to use the wrong tag of the container image. Since kubectl-trace and IG have similar architecture, that could help here. At the moment, my setup only really works with people who have rights on the upstream GitHub organization but that's something that I want to improve (inspektor-gadget/inspektor-gadget#31).

I am interested in testing on different Linux versions & Kubernetes versions too. I wanted to explore the self hosted runner but haven't so far. If you find how to set it up, I am interested :)

@fntlnz
Copy link
Member

fntlnz commented May 20, 2020

I like this idea too!

dalehamel added a commit to dalehamel/kubectl-trace that referenced this issue Oct 22, 2020
This moves the CI and release process to github actions from Travis
dalehamel added a commit to dalehamel/kubectl-trace that referenced this issue Oct 22, 2020
This moves the CI and release process to github actions from Travis
@fntlnz fntlnz closed this as completed in 656bfea Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants