Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate travis CI to github actions, fixes #105 #132

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

dalehamel
Copy link
Member

This moves the CI and release process to github actions from Travis for #105

To fully test this, I will need to either be made a full admin of the repo (@fntlnz @leodido are you able to do this?), or have an existing admin add the QUAY_TOKEN secret environment variable.

Here is a sample run: https://github.com/dalehamel/kubectl-trace/actions/runs/322349438

It uploads the dist folder for cross builds, as well as the linux binary that it builds as part of the test process.

I plan on testing the gorelease script when we cut 0.1.1 shortly

@dalehamel dalehamel changed the title [feat] Migrate travis CI to github actions, fixes #105 feat: Migrate travis CI to github actions, fixes #105 Oct 22, 2020
This moves the CI and release process to github actions from Travis
@dalehamel dalehamel mentioned this pull request Oct 22, 2020
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very cool!

@fntlnz
Copy link
Member

fntlnz commented Oct 26, 2020

Good job @dalehamel - this is very useful and better than what we had.

@fntlnz fntlnz merged commit 656bfea into iovisor:master Oct 26, 2020
@fntlnz
Copy link
Member

fntlnz commented Oct 26, 2020

I removed Fixmie from the list of requirements for merge in Branch protection rules (that app does not exist anymore).

I wanted to add the new checks from here as required but they don't appear. I guess there's some caching and I'll check later

image

@fntlnz
Copy link
Member

fntlnz commented Oct 26, 2020

oh wait! The new ones are build_and_test prefixed.
Enabled them

image

@dalehamel
Copy link
Member Author

Oh this wasn't quite ready to merge, I discovered a couple more things. I'll follow-up with another PR to correct those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants