-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic krew releases #119
Comments
if it is in krew as "kubectl trace," i think that this adds even more fuel to the argument of making tracers generic, as that's where I first saw this called out |
#17 (comment) is the comment i refer to above |
Hi Team thanks for the awesome plugin. I found this today while reading/learning about ebpf I am also the author of I noticed that current release version is a I will be happy to open PR for adding Many thanks |
hi @rajatjindal @zqureshi and I are in the process of cutting v0.1.1 (per #133 ) what steps must be taken to ensure that the bot correctly releases this when it is prepared? |
Ok I’ve moved us over to GitHub actions so this looks like we can hook this up for the v0.1.1 release |
Looks like we just need to modify a boilerplate like https://github.com/rajatjindal/kubectl-evict-pod/blob/master/.krew.yaml and then add agithub action, which we can do on the goreleaser.yml |
Thanks for considering to use krew release bot You could also use https://rajatjindal.com/tools/krew-release-bot-helper/ to generate template file for your plugin Once u have the krew template file in, and github action configured, the bot should take it from there when u do a release. (It does not work for pre releases) I will keep an eye on this ticket incase we run into any issues |
Thanks @rajatjindal just a heads-up the tool is 500’ing |
Thanks for trying that out, and the heads up. I will check whats going on. One common UX issue i have observed on that tool is that it accepts the name as e.g. "trace" instead of "kubectl-trace" |
I think this is the normal naming for kubernetes plugins? So it can be called |
#140 up for review |
Now that we are integrated with Krew, we'd love to avoid having to manually update Krew every time we release kubectl trace.
Instructions here: https://krew.sigs.k8s.io/docs/developer-guide/release/automating-updates/
The text was updated successfully, but these errors were encountered: