-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kubectl trace v0.1.0-rc.1 #658
Conversation
Welcome @fntlnz! |
I suspect neither of the maintainers have a windows box. :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as you know that your plugin runs on windows, it should be fine to also distribute the windows plugin. Binaries (.exe) usually work well---if you ignore the general hazzle of symlinks on windows. So I'm not too worried about this.
Thanks for contributing this. Very exciting to have it in krew-index!
Signed-off-by: Lorenzo Fontana <[email protected]>
@ahmetb @corneliusweig I just addressed all the suggestions and tested again. Thank you two for the reviews, I really appreciate it. And thanks for this awesome tool! |
Created the corresponding PR on kubectl trace for when this is merged. iovisor/kubectl-trace#118 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So cool to finally have this in krew-index
! For best impact, I'd advise to improve the description a bit.
Signed-Off-By: Lorenzo Fontana <[email protected]> Co-authored-by: Cornelius Weig <[email protected]>
Thanks for your suggestions @corneliusweig - updated! |
It seems |
Signed-off-by: Lorenzo Fontana <[email protected]>
@ahmetb you're right the description is not what I wanted - updated it! Wow didn't know this could be automated! Good work, thanks @ahmetb ! I opened an issue to do that iovisor/kubectl-trace#119 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, fntlnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks everyone! |
Happy to submit kubectl trace to the krew index as per the discussions happening one year ago in iovisor/kubectl-trace#17
Sorry if it took a long time!
Adding a wip since I didn't test the manifest on all platforms yet.
If anyone can test it on windows before I do and report here I'll be grateful.
Signed-off-by: Lorenzo Fontana [email protected]