fix: Migrate release process to github actions #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fntlnz
previously approved these changes
Oct 26, 2020
leodido
previously approved these changes
Oct 26, 2020
I think that's a reasonable default and perhaps a flag to use the latest image might also be ok. |
zqureshi
reviewed
Oct 27, 2020
zqureshi
reviewed
Oct 27, 2020
zqureshi
reviewed
Oct 27, 2020
leodido
previously approved these changes
Oct 27, 2020
leodido
force-pushed
the
release-improvements
branch
from
b469d79 to
400eb18
Compare
leodido
previously approved these changes
Oct 27, 2020
dalehamel
force-pushed
the
release-improvements
branch
from
400eb18 to
e40f246
Compare
This completely replaces the existing Travis-based scripts with Github Actions. - Images now built by CI will receive a docker tag corresponding to their git tag - Go release is called when any tag is pushed, which will use Github Actions to create the Github Release, and uploads cross-compiled Go binaries to it.
dalehamel
force-pushed
the
release-improvements
branch
from
e40f246 to
221aa46
Compare
seanmalloy
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes up the work on #132, and is a re-do of #134
This completely replaces the existing Travis-based scripts with Github Actions.
to create the Github Release, and uploads cross-compiled Go binaries to it.
In addition, the current process is generic enough to run on any personal fork also, making it trivial for others to deploy their own kubectl-trace should they desire to.
Here is a sample test release created by this on my own fork:
https://github.com/dalehamel/kubectl-trace/releases/tag/v0.1.1-pre3
While this does add git tags to the docker images, I think we still need a way to set what default image to use, probably via another LDFlag, like we do in the tests. We can follow up with this in another PR, as I think @fntlnz and @zqureshi have already discussed this. I think a good default behavior would just be to default to a version tag the same as the binary version, as that should already be pushed by the changes in this PR.