feat: allow ignoring protoc version comments in go generate check #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galargh
added a commit
to libp2p/go-libp2p
that referenced
this pull request
Oct 12, 2023
galargh
commented
Oct 13, 2023
galargh
commented
Oct 13, 2023
galargh
commented
Oct 13, 2023
galargh
commented
Oct 13, 2023
galargh
commented
Oct 13, 2023
galargh
commented
Oct 13, 2023
marten-seemann
approved these changes
Oct 27, 2023
Comment on lines
+93
to
+94
| git config --global user.email "41898282+github-actions[bot]@users.noreply.github.com" | ||
| git config --global user.name "github-actions[bot]" |
There was a problem hiding this comment.
Do I understand correctly that this won't be actually commit the repo? Is this commit only used on CI?
There was a problem hiding this comment.
Yes, that's 100% right. We're only making a local commit to make it easier to check the diff. But even for local commits, git wants us to set user details.
|
@laurentsenta FYI, I want to merge it by tomorrow. Let me know if you have any reservations. |
laurentsenta
approved these changes
Oct 30, 2023
|
Merging, I'll cut a new release tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26
Tested in libp2p/go-libp2p#2603. I'll create a PR to go-libp2p that enables the newly added option after I release the new patch version of uCI which will be shortly after this is merged.