Skip to content

Commit

Permalink
closes #342
Browse files Browse the repository at this point in the history
  • Loading branch information
rafapereirabr committed Jul 14, 2023
1 parent 20d5f9a commit 768a662
Show file tree
Hide file tree
Showing 12 changed files with 28 additions and 24 deletions.
4 changes: 4 additions & 0 deletions r-package/NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# r5r 1.0.1

**Minor changes**

- The default value of `time_window` is not set to 10 minutes in all functions to avoid weird results reported upstream in R5. Closes [#342](https://github.com/ipeaGIT/r5r/issues/342).

**Bug fixes**

* Updated to R5 version 6.9. This fixed a few bugs upstream, one of which often prevented users to build a network using cropped OSM data. Closes [#325](https://github.com/ipeaGIT/r5r/issues/325).
Expand Down
2 changes: 1 addition & 1 deletion r-package/R/accessibility.R
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ accessibility <- function(r5r_core,
mode = "WALK",
mode_egress = "WALK",
departure_datetime = Sys.time(),
time_window = 1L,
time_window = 10L,
percentiles = 50L,
decay_function = "step",
cutoffs = NULL,
Expand Down
6 changes: 3 additions & 3 deletions r-package/R/detailed_itineraries.R
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
#' @template fare_structure
#' @template max_fare
#' @param time_window An integer. The time window in minutes for which `r5r`
#' will calculate multiple itineraries departing each minute. Defaults to 1
#' minute. If the same sequence of routes appear in different minutes of the
#' will calculate multiple itineraries departing each minute. Defaults to 10
#' minutes. If the same sequence of routes appear in different minutes of the
#' time window, only the fastest of them will be kept in the output. This
#' happens because the result is not aggregated by percentile, as opposed to
#' other routing functions in the package. Because of that, the output may
Expand Down Expand Up @@ -90,7 +90,7 @@ detailed_itineraries <- function(r5r_core,
mode = "WALK",
mode_egress = "WALK",
departure_datetime = Sys.time(),
time_window = 1L,
time_window = 10L,
suboptimal_minutes = 0L,
fare_structure = NULL,
max_fare = Inf,
Expand Down
2 changes: 1 addition & 1 deletion r-package/R/expanded_travel_time_matrix.R
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ expanded_travel_time_matrix <- function(r5r_core,
mode = "WALK",
mode_egress = "WALK",
departure_datetime = Sys.time(),
time_window = 1L,
time_window = 10L,
breakdown = FALSE,
max_walk_time = Inf,
max_bike_time = Inf,
Expand Down
2 changes: 1 addition & 1 deletion r-package/R/pareto_frontier.R
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ pareto_frontier <- function(r5r_core,
mode = c("WALK", "TRANSIT"),
mode_egress = "WALK",
departure_datetime = Sys.time(),
time_window = 1L,
time_window = 10L,
percentiles = 50L,
max_walk_time = Inf,
max_bike_time = Inf,
Expand Down
2 changes: 1 addition & 1 deletion r-package/R/travel_time_matrix.R
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ travel_time_matrix <- function(r5r_core,
mode = "WALK",
mode_egress = "WALK",
departure_datetime = Sys.time(),
time_window = 1L,
time_window = 10L,
percentiles = 50L,
fare_structure = NULL,
max_fare = Inf,
Expand Down
6 changes: 3 additions & 3 deletions r-package/man/accessibility.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions r-package/man/detailed_itineraries.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions r-package/man/expanded_travel_time_matrix.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions r-package/man/pareto_frontier.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions r-package/man/roxygen/templates/time_window_related_args.R
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#' @param time_window An integer. The time window in minutes for which `r5r`
#' will calculate multiple travel time matrices departing each minute.
#' Defaults to 1 minute. By default, the function returns the result based on
#' median travel times, but the user can set the `percentiles` parameter to
#' Defaults to 10 minutes. By default, the function returns the result based
#' on median travel times, but the user can set the `percentiles` parameter to
#' extract more results. Please read the time window vignette for more details
#' on its usage `vignette("time_window", package = "r5r")`
6 changes: 3 additions & 3 deletions r-package/man/travel_time_matrix.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 768a662

Please sign in to comment.