Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove helia.io cname #666

Merged
merged 2 commits into from
Oct 30, 2024
Merged

fix: remove helia.io cname #666

merged 2 commits into from
Oct 30, 2024

Conversation

2color
Copy link
Member

@2color 2color commented Oct 25, 2024

Description

  • This PR removes the config which sets the custom domain used for GitHub pages. Historically, the docs were deployed to the helia.io domain, however, since we introduced a website for the docs, we no longer want this.
  • When a custom domain is configured, Github will redirect from the github.io domain to the custom domain
  • fixes Documentation is down #655

Note

I have also manually removed the custom domain from the site config to ensure this works.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@2color 2color requested a review from a team as a code owner October 25, 2024 12:38
@2color 2color mentioned this pull request Oct 25, 2024
@2color 2color merged commit dff82ec into main Oct 30, 2024
19 checks passed
@2color 2color deleted the fix-docs-redirect branch October 30, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation is down
1 participant